Re: [PATCH 1/2] marvell-cam: Build fix: mcam->platform assignment

2012-04-26 Thread Chris Ball
Hi, On Thu, Apr 26 2012, Jonathan Corbet wrote: > On Thu, 26 Apr 2012 16:07:25 -0400 > Chris Ball wrote: > >> It seems that this driver has never been buildable upstream, because it >> was merged with this line included: >> >>mcam->platform = MHP_Armada610; > > Yes, that was from a badly

Re: [PATCH 1/2] marvell-cam: Build fix: mcam->platform assignment

2012-04-26 Thread Jonathan Corbet
On Thu, 26 Apr 2012 16:07:25 -0400 Chris Ball wrote: > It seems that this driver has never been buildable upstream, because it > was merged with this line included: > >mcam->platform = MHP_Armada610; Yes, that was from a badly cherry-picked change a while back. I sent in a fix (the sam

[PATCH 1/2] marvell-cam: Build fix: mcam->platform assignment

2012-04-26 Thread Chris Ball
It seems that this driver has never been buildable upstream, because it was merged with this line included: mcam->platform = MHP_Armada610; which causes: drivers/media/video/marvell-ccic/mmp-driver.c:184:6: error: 'struct mcam_camera' has no member named 'platform' drivers/media/video/ma