Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-25 Thread Bryan Wu
On 08/25/2015 06:44 AM, Thierry Reding wrote: On Mon, Aug 24, 2015 at 05:26:20PM -0700, Bryan Wu wrote: On 08/21/2015 06:03 AM, Thierry Reding wrote: On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: [...] +{ + if (chan->bypass) + return; I don't see this being se

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-25 Thread Bryan Wu
On 08/24/2015 11:30 PM, Hans Verkuil wrote: A quick follow-up to Thierry's excellent review: On 08/25/2015 02:26 AM, Bryan Wu wrote: On 08/21/2015 06:03 AM, Thierry Reding wrote: On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: +static void +__tegra_channel_try_format(struct tegra

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-25 Thread Thierry Reding
On Tue, Aug 25, 2015 at 04:15:58PM +0200, Hans Verkuil wrote: > On 08/25/15 15:44, Thierry Reding wrote: > > On Mon, Aug 24, 2015 at 05:26:20PM -0700, Bryan Wu wrote: [...] > > > For CMA we need increase the default memory size. > > > > I'd rather not rely on CMA at all, especially since we do hav

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-25 Thread Hans Verkuil
On 08/25/15 15:44, Thierry Reding wrote: > On Mon, Aug 24, 2015 at 05:26:20PM -0700, Bryan Wu wrote: >> On 08/21/2015 06:03 AM, Thierry Reding wrote: >>> On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: +{ + if (chan->bypass) + return; >>> I don't see this being se

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-25 Thread Thierry Reding
On Mon, Aug 24, 2015 at 05:26:20PM -0700, Bryan Wu wrote: > On 08/21/2015 06:03 AM, Thierry Reding wrote: > >On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: [...] > >>+#define TEGRA_CSI_PHY_CIL_COMMAND 0x0908 > >This doesn't seem to be used at all. > > Actually this PHY

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-25 Thread Thierry Reding
On Tue, Aug 25, 2015 at 08:30:41AM +0200, Hans Verkuil wrote: > A quick follow-up to Thierry's excellent review: > > On 08/25/2015 02:26 AM, Bryan Wu wrote: > > On 08/21/2015 06:03 AM, Thierry Reding wrote: > >> On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: > > > > >>> +static void

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-24 Thread Hans Verkuil
A quick follow-up to Thierry's excellent review: On 08/25/2015 02:26 AM, Bryan Wu wrote: > On 08/21/2015 06:03 AM, Thierry Reding wrote: >> On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: >>> +static void >>> +__tegra_channel_try_format(struct tegra_channel *chan, struct >>> v4l2_pix

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-24 Thread Bryan Wu
On 08/21/2015 02:28 AM, Hans Verkuil wrote: Hi Bryan, Thanks for contributing this driver, very much appreciated. I do have some comments below, basically about the same things we discussed privately before. On 08/21/2015 02:51 AM, Bryan Wu wrote: NVIDIA Tegra processor contains a powerful Vi

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-24 Thread Bryan Wu
On 08/21/2015 06:03 AM, Thierry Reding wrote: On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: NVIDIA Tegra processor contains a powerful Video Input (VI) hardware controller which can support up to 6 MIPI CSI camera sensors. This patch adds a V4L2 media controller and capture driver t

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-21 Thread Hans Verkuil
On 08/21/2015 03:03 PM, Thierry Reding wrote: > On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: >> NVIDIA Tegra processor contains a powerful Video Input (VI) hardware >> controller which can support up to 6 MIPI CSI camera sensors. >> >> This patch adds a V4L2 media controller and captur

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-21 Thread Thierry Reding
On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: > NVIDIA Tegra processor contains a powerful Video Input (VI) hardware > controller which can support up to 6 MIPI CSI camera sensors. > > This patch adds a V4L2 media controller and capture driver to support > Tegra VI hardware. It's verif

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-21 Thread Hans Verkuil
Hi Bryan, Thanks for contributing this driver, very much appreciated. I do have some comments below, basically about the same things we discussed privately before. On 08/21/2015 02:51 AM, Bryan Wu wrote: > NVIDIA Tegra processor contains a powerful Video Input (VI) hardware > controller which ca

[PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-20 Thread Bryan Wu
NVIDIA Tegra processor contains a powerful Video Input (VI) hardware controller which can support up to 6 MIPI CSI camera sensors. This patch adds a V4L2 media controller and capture driver to support Tegra VI hardware. It's verified with Tegra built-in test pattern generator. Signed-off-by: Brya

[PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-20 Thread Bryan Wu
NVIDIA Tegra processor contains a powerful Video Input (VI) hardware controller which can support up to 6 MIPI CSI camera sensors. This patch adds a V4L2 media controller and capture driver to support Tegra VI hardware. It's verified with Tegra built-in test pattern generator. Signed-off-by: Brya