Re: [PATCH 1/2] [media] r820t: fix nint range check

2013-09-30 Thread Mauro Carvalho Chehab
Em Mon, 30 Sep 2013 12:46:52 -0400 Michael Krufky escreveu: > Do you have any comments on this, Mauro? > > Assuming that Mauro is OK with this change, (since he is the author of > this driver) then yes - please resubmit the patch with some > explanation within comments inline or within the commi

Re: [PATCH 1/2] [media] r820t: fix nint range check

2013-09-30 Thread Jiří Pinkava
Mike, unfortunately no documentation can be referenced except preliminary version of datasheet (1).This change is based on lucky guess and supported by lot of testing on real hardware. This change add support for devices with Xtal frequency bellow 28.8MHz. >From Nint are computed values of Ni a

Re: [PATCH 1/2] [media] r820t: fix nint range check

2013-09-30 Thread Michael Krufky
Do you have any comments on this, Mauro? Assuming that Mauro is OK with this change, (since he is the author of this driver) then yes - please resubmit the patch with some explanation within comments inline or within the commit message. Best regards, Mike Krufky On Mon, Sep 30, 2013 at 12:42 PM

Re: [PATCH 1/2] [media] r820t: fix nint range check

2013-09-30 Thread Michael Krufky
Jiří, Do you have any documentation that supports this value change? Changing this value affects the algorithm, and we'd be happier making this change if the patch included some better description and perhaps a reference explaining why the new value is correct. Regards, Mike Krufky On Sun, Sep

[PATCH 1/2] [media] r820t: fix nint range check

2013-09-29 Thread Jiří Pinkava
Use full range of VCO parameters, fixes tunning for some frequencies. --- drivers/media/tuners/r820t.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c index 1c23666..e25c720 100644 --- a/drivers/media/tuners/r820t.c