Re: [PATCH 1/2] [media] dib0700: Drop useless check when remote key is pressed

2012-03-21 Thread Jean Delvare
Hi Mauro, On Tue, 20 Mar 2012 09:17:54 -0300, Mauro Carvalho Chehab wrote: > Em 20-03-2012 04:20, Jean Delvare escreveu: > > On Mon, 19 Mar 2012 19:26:11 -0300, Mauro Carvalho Chehab wrote: > >> Yet, I'd be more happy if Jean's patch could check first if the status is > >> below 0, in order to pre

Re: [PATCH 1/2] [media] dib0700: Drop useless check when remote key is pressed

2012-03-20 Thread Mauro Carvalho Chehab
Em 20-03-2012 04:20, Jean Delvare escreveu: > Hi Mauro, > > On Mon, 19 Mar 2012 19:26:11 -0300, Mauro Carvalho Chehab wrote: >> On Tue, Mar 13, 2012 at 1:50 PM, Jean Delvare wrote: >>> --- linux-3.3-rc7.orig/drivers/media/dvb/dvb-usb/dib0700_core.c >>> 2012-03-13 11:09:13.0 +0100 >>

Re: [PATCH 1/2] [media] dib0700: Drop useless check when remote key is pressed

2012-03-20 Thread Jean Delvare
Hi Mauro, On Mon, 19 Mar 2012 19:26:11 -0300, Mauro Carvalho Chehab wrote: > On Tue, Mar 13, 2012 at 1:50 PM, Jean Delvare wrote: > > --- linux-3.3-rc7.orig/drivers/media/dvb/dvb-usb/dib0700_core.c > > 2012-03-13 11:09:13.0 +0100 > > +++ linux-3.3-rc7/drivers/media/dvb/dvb-usb/dib07

Re: [PATCH 1/2] [media] dib0700: Drop useless check when remote key is pressed

2012-03-19 Thread Mauro Carvalho Chehab
Em 13-03-2012 14:57, Devin Heitmueller escreveu: > On Tue, Mar 13, 2012 at 1:50 PM, Jean Delvare wrote: >> struct dvb_usb_device *d can never be NULL so don't waste time >> checking for this. >> >> Rationale: the urb's context is set when usb_fill_bulk_urb() is called >> in dib0700_rc_setup(), and

Re: [PATCH 1/2] [media] dib0700: Drop useless check when remote key is pressed

2012-03-13 Thread Devin Heitmueller
On Tue, Mar 13, 2012 at 1:50 PM, Jean Delvare wrote: > struct dvb_usb_device *d can never be NULL so don't waste time > checking for this. > > Rationale: the urb's context is set when usb_fill_bulk_urb() is called > in dib0700_rc_setup(), and never changes after that. d is dereferenced > unconditi

[PATCH 1/2] [media] dib0700: Drop useless check when remote key is pressed

2012-03-13 Thread Jean Delvare
struct dvb_usb_device *d can never be NULL so don't waste time checking for this. Rationale: the urb's context is set when usb_fill_bulk_urb() is called in dib0700_rc_setup(), and never changes after that. d is dereferenced unconditionally in dib0700_rc_setup() so it can't be NULL or the driver wo