Re: [PATCH 08/12] v4l2-compat-ioctl32.c: fix ctrl_is_pointer

2018-01-29 Thread Mauro Carvalho Chehab
Em Sun, 28 Jan 2018 01:18:57 +0200 Sakari Ailus escreveu: > Hi Hans, > ... > > + > > + if (ops->vidioc_query_ext_ctrl) > > + ret = ops->vidioc_query_ext_ctrl(file, fh, &qec); > > Is there a need for this? > > The only driver implementing vidioc_query_ext_ctrl op is the uvcvideo

Re: [PATCH 08/12] v4l2-compat-ioctl32.c: fix ctrl_is_pointer

2018-01-27 Thread Sakari Ailus
Hi Hans, On Fri, Jan 26, 2018 at 01:43:23PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > ctrl_is_pointer just hardcoded two known string controls, but that > caused problems when using e.g. custom controls that use a pointer > for the payload. > > Reimplement this function: it now finds

[PATCH 08/12] v4l2-compat-ioctl32.c: fix ctrl_is_pointer

2018-01-26 Thread Hans Verkuil
From: Hans Verkuil ctrl_is_pointer just hardcoded two known string controls, but that caused problems when using e.g. custom controls that use a pointer for the payload. Reimplement this function: it now finds the v4l2_ctrl (if the driver uses the control framework) or it calls vidioc_query_ext_