Re: [PATCH 07/24] xc5000: properly report i2c write failures

2014-02-10 Thread Devin Heitmueller
On Mon, Feb 10, 2014 at 3:25 AM, Joonyoung Shim wrote: > As you said, i modified like below patch and it is working well. > > Thanks for your advice. > > diff --git a/drivers/media/usb/au0828/au0828-cards.c > b/drivers/media/usb/au0828/au0828-cards.c > index 0cb7c28..9936875 100644 > --- a/drivers

Re: [PATCH 07/24] xc5000: properly report i2c write failures

2014-02-10 Thread Joonyoung Shim
Hi Devin, 2014-02-07 22:46 GMT+09:00 Devin Heitmueller : > > > I can't load firmware like error of below link. > > > > https://bugs.launchpad.net/ubuntu/+source/linux-firmware-nonfree/+bug/1263837 > > > > This error is related with this patch. This fix is right but above error is > > created after

Re: [PATCH 07/24] xc5000: properly report i2c write failures

2014-02-07 Thread Devin Heitmueller
> I can't load firmware like error of below link. > > https://bugs.launchpad.net/ubuntu/+source/linux-firmware-nonfree/+bug/1263837 > > This error is related with this patch. This fix is right but above error is > created after this fix > because my device makes WatchDogTimer to 0 when load firmwar

Re: [PATCH 07/24] xc5000: properly report i2c write failures

2014-02-07 Thread Joonyoung Shim
Hi, Sorry for response about the past post. The logic as written would *never* actually return an error condition, since the loop would run until the counter hit zero but the check was for a value less than zero. Signed-off-by: Devin Heitmueller --- drivers/media/common/tuners/xc5000.c |

[PATCH 07/24] xc5000: properly report i2c write failures

2012-08-06 Thread Devin Heitmueller
The logic as written would *never* actually return an error condition, since the loop would run until the counter hit zero but the check was for a value less than zero. Signed-off-by: Devin Heitmueller --- drivers/media/common/tuners/xc5000.c |2 +- 1 files changed, 1 insertions(+), 1 deleti