Re: [PATCH 05/11] ov534: Fix setting manual exposure

2010-03-01 Thread Antonio Ospite
On Sun, 28 Feb 2010 19:54:25 +0100 Antonio Ospite wrote: > On Sun, 28 Feb 2010 19:38:14 +0100 > Jean-Francois Moine wrote: > > > On Sat, 27 Feb 2010 21:20:22 +0100 > > Antonio Ospite wrote: > > > > > Exposure is now a u16 value, both MSB and LSB are set, but values in > > > the v4l2 control a

Re: [PATCH 05/11] ov534: Fix setting manual exposure

2010-02-28 Thread Jean-Francois Moine
On Sun, 28 Feb 2010 19:54:25 +0100 Antonio Ospite wrote: > JF, the intent here is to cover all the range of values available in > Auto Exposure mode too, doesn't this make sense to you? > > I could set .maximum to 253 to limit the "UI" control precision but > then I should use 2*value when setti

Re: [PATCH 05/11] ov534: Fix setting manual exposure

2010-02-28 Thread Antonio Ospite
On Sun, 28 Feb 2010 19:38:14 +0100 Jean-Francois Moine wrote: > On Sat, 27 Feb 2010 21:20:22 +0100 > Antonio Ospite wrote: > > > Exposure is now a u16 value, both MSB and LSB are set, but values in > > the v4l2 control are limited to the interval [0,506] as 0x01fa (506) > > is the maximum obser

Re: [PATCH 05/11] ov534: Fix setting manual exposure

2010-02-28 Thread Jean-Francois Moine
On Sat, 27 Feb 2010 21:20:22 +0100 Antonio Ospite wrote: > Exposure is now a u16 value, both MSB and LSB are set, but values in > the v4l2 control are limited to the interval [0,506] as 0x01fa (506) > is the maximum observed value with AEC enabled. [snip] > .type= V4L2_CTRL_

[PATCH 05/11] ov534: Fix setting manual exposure

2010-02-27 Thread Antonio Ospite
Exposure is now a u16 value, both MSB and LSB are set, but values in the v4l2 control are limited to the interval [0,506] as 0x01fa (506) is the maximum observed value with AEC enabled. Skip setting exposure when AEC is enabled. Signed-off-by: Antonio Ospite --- linux/drivers/media/video/gspca/