Re: [PATCH 03/19] em28xx: start moving em28xx-v4l specific data to its own struct

2014-05-12 Thread Hans Verkuil
On 05/11/2014 10:46 PM, Frank Schäfer wrote: > > Am 09.05.2014 11:17, schrieb Hans Verkuil: >> Some comments for future improvements: >> >> On 03/24/2014 08:33 PM, Frank Schäfer wrote: >>> Signed-off-by: Frank Schäfer >>> --- >>> drivers/media/usb/em28xx/em28xx-camera.c | 4 +- >>> drivers/med

Re: [PATCH 03/19] em28xx: start moving em28xx-v4l specific data to its own struct

2014-05-11 Thread Frank Schäfer
Am 09.05.2014 11:17, schrieb Hans Verkuil: > Some comments for future improvements: > > On 03/24/2014 08:33 PM, Frank Schäfer wrote: >> Signed-off-by: Frank Schäfer >> --- >> drivers/media/usb/em28xx/em28xx-camera.c | 4 +- >> drivers/media/usb/em28xx/em28xx-video.c | 160 >>

Re: [PATCH 03/19] em28xx: start moving em28xx-v4l specific data to its own struct

2014-05-09 Thread Hans Verkuil
Some comments for future improvements: On 03/24/2014 08:33 PM, Frank Schäfer wrote: > Signed-off-by: Frank Schäfer > --- > drivers/media/usb/em28xx/em28xx-camera.c | 4 +- > drivers/media/usb/em28xx/em28xx-video.c | 160 > +-- > drivers/media/usb/em28xx/em28xx.h

[PATCH 03/19] em28xx: start moving em28xx-v4l specific data to its own struct

2014-03-24 Thread Frank Schäfer
Signed-off-by: Frank Schäfer --- drivers/media/usb/em28xx/em28xx-camera.c | 4 +- drivers/media/usb/em28xx/em28xx-video.c | 160 +-- drivers/media/usb/em28xx/em28xx.h| 8 +- 3 files changed, 116 insertions(+), 56 deletions(-) diff --git a/drivers/media/us