Hi Guennadi,
[snip]
>> [Libin] Yes, you are right. We should consider the driver may be reused.
>> I didn't realize it. Another question is: If we use devm_clk_get(), what
>> I understand, the clk will be put when the device is being released. It
>> means the driver will hold the clk all the time
media@vger.kernel.org
> >Subject: RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for
> >marvell-ccic driver
> >
> >On Tue, 27 Nov 2012, Libin Yang wrote:
> >
> >> Hello Guennadi,
> >>
> >> Please see my comments below.
> >>
; >Sent: Tuesday, November 27, 2012 7:21 PM
>> >To: Guennadi Liakhovetski
>> >Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
>> >Subject: RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for
>> >marvell-ccic
>driver
>> >
>
>Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
> >Subject: RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for
> >marvell-ccic driver
> >
> >Hi, Guennadi
> >
> >We will update the patch by following your good suggest
edia] marvell-ccic: add MIPI support for
>marvell-ccic driver
>
>Hi, Guennadi
>
>We will update the patch by following your good suggestion! :)
>
[snip]
>>> + pll1 = clk_get(dev, "pll1");
>>> + if (IS_ERR(pll1)) {
>>> +
ng
>Subject: Re: [PATCH 02/15] [media] marvell-ccic: add MIPI support for
>marvell-ccic driver
>
>Hi Albert
>
>A general question first: is the MIPI CSI-2 implementation common to all ccic
>variants or
>specific to your SoC?
>
I think it's for all marvell ccic.
>
Hi Albert
A general question first: is the MIPI CSI-2 implementation common to all
ccic variants or specific to your SoC?
On Fri, 23 Nov 2012, Albert Wang wrote:
> From: Libin Yang
>
> This patch adds the MIPI support for marvell-ccic.
> Board driver should determine whether using MIPI or not
From: Libin Yang
This patch adds the MIPI support for marvell-ccic.
Board driver should determine whether using MIPI or not.
Signed-off-by: Albert Wang
Signed-off-by: Libin Yang
---
drivers/media/platform/marvell-ccic/mcam-core.c | 60 ++
drivers/media/platform/marvell-ccic
