Re: [PATCH 01/16] [media] dib0700: get rid of on-stack dma buffers

2011-03-15 Thread Florian Mickler
On Tue, 15 Mar 2011 09:02:00 -0300 Mauro Carvalho Chehab wrote: > > You're allocating a buffer for URB control messages. IMO, this is a good > idea, as > this way, allocating/freeing on each urb call is avoided. However, on most > places, > you're not using it. The better would be to just use t

Re: [PATCH 01/16] [media] dib0700: get rid of on-stack dma buffers

2011-03-15 Thread Mauro Carvalho Chehab
Em 15-03-2011 05:43, Florian Mickler escreveu: > usb_control_msg initiates (and waits for completion of) a dma transfer using > the supplied buffer. That buffer thus has to be seperately allocated on > the heap. > > In lib/dma_debug.c the function check_for_stack even warns about it: > WARNI

[PATCH 01/16] [media] dib0700: get rid of on-stack dma buffers

2011-03-15 Thread Florian Mickler
usb_control_msg initiates (and waits for completion of) a dma transfer using the supplied buffer. That buffer thus has to be seperately allocated on the heap. In lib/dma_debug.c the function check_for_stack even warns about it: WARNING: at lib/dma-debug.c:866 check_for_stack Note: This ch