Re: [PATCH 00/13] Remaining coding style clean up of AS102 driver

2011-11-08 Thread Sylwester Nawrocki
On 11/08/2011 02:36 PM, Mauro Carvalho Chehab wrote: > I got a few warnings here, after applying the patch series: > > drivers/staging/media/as102/as102_drv.c: In function ‘as102_dvb_register’: > drivers/staging/media/as102/as102_drv.c:223:3: warning: passing argument 1 of > ‘dev_err’ from incomp

Re: [PATCH 00/13] Remaining coding style clean up of AS102 driver

2011-11-08 Thread Mauro Carvalho Chehab
Em 06-11-2011 18:31, Sylwester Nawrocki escreveu: > Hello, > > the following patch set is a further cleanup of the AS102 DVB-T receiver > driver. I'm not sure if there are more issues to address before moving > the driver to drivers/media/dvb/, but checkpatch.pl seems now to be fairly > happy ab

Re: [PATCH 00/13] Remaining coding style clean up of AS102 driver

2011-11-07 Thread Devin Heitmueller
On Mon, Nov 7, 2011 at 2:57 PM, Sylwester Nawrocki wrote: > My knowledge about this driver is rather limited, in case of any issues I > guess it's best to ask Devin directly. Part of the problem here is that the as102 chip is a fully programmable part, and as a result the firmware may differ on a

Re: [PATCH 00/13] Remaining coding style clean up of AS102 driver

2011-11-07 Thread Sylwester Nawrocki
Hi Gianluca, On 11/07/2011 05:09 PM, Gianluca Gennari wrote: > Hi Sylwestwer, > I was about to test the new driver when I discovered that my as102 > device is not included in the list of supported devices: > > /* Super Digi KEY */ > #define AS102_SUPER_DIGI_NAME "Super Digi KEY" > #define SUPER_D

Re: [PATCH 00/13] Remaining coding style clean up of AS102 driver

2011-11-07 Thread Sylwester Nawrocki
Hi Gianluca, On 11/07/2011 04:19 PM, Gianluca Gennari wrote: > Hi Sylwester, > I spotted a minor error in file as102_drv.c line 233: > in a call to function "dev_err", the first "dev" parameter is missing. > This produces a compilation warning. Thanks for pointing that out, not sure how I have ma

[PATCH 00/13] Remaining coding style clean up of AS102 driver

2011-11-06 Thread Sylwester Nawrocki
Hello, the following patch set is a further cleanup of the AS102 DVB-T receiver driver. I'm not sure if there are more issues to address before moving the driver to drivers/media/dvb/, but checkpatch.pl seems now to be fairly happy about the driver's state: 8<-- $ scripts/checkpatch.pl -f d