Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-12 Thread Mauro Carvalho Chehab
Em 12-11-2010 12:08, David Härdeman escreveu: > On Fri, Nov 12, 2010 at 10:56:34AM -0200, Mauro Carvalho Chehab wrote: >> Em 12-11-2010 10:12, David Härdeman escreveu: >>> Shouldn't platform_data be const? And you'll break the refcounting >>> done in rc_allocate_device() and rc_free_device() / >>>

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-12 Thread David Härdeman
On Fri, Nov 12, 2010 at 10:56:34AM -0200, Mauro Carvalho Chehab wrote: >Em 12-11-2010 10:12, David Härdeman escreveu: >> Shouldn't platform_data be const? And you'll break the refcounting >> done in rc_allocate_device() and rc_free_device() / >> rc_unregister_device(). Not to mention the silent bu

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-12 Thread Mauro Carvalho Chehab
Em 12-11-2010 10:12, David Härdeman escreveu: > On Fri, Nov 12, 2010 at 02:00:55AM -0200, Mauro Carvalho Chehab wrote: >> Em 11-11-2010 21:40, Jarod Wilson escreveu: >>> On Thu, Nov 11, 2010 at 3:35 PM, David Härdeman wrote: On Thu, Nov 11, 2010 at 02:00:38PM -0200, Mauro Carvalho Chehab wrot

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-12 Thread David Härdeman
On Fri, Nov 12, 2010 at 02:00:55AM -0200, Mauro Carvalho Chehab wrote: >Em 11-11-2010 21:40, Jarod Wilson escreveu: >> On Thu, Nov 11, 2010 at 3:35 PM, David Härdeman wrote: >>> On Thu, Nov 11, 2010 at 02:00:38PM -0200, Mauro Carvalho Chehab wrote: A good exercise would be to port lirc-zilog

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-12 Thread David Härdeman
On Thu, Nov 11, 2010 at 06:40:42PM -0500, Jarod Wilson wrote: >On Thu, Nov 11, 2010 at 3:35 PM, David Härdeman wrote: >> On Thu, Nov 11, 2010 at 02:00:38PM -0200, Mauro Carvalho Chehab wrote: >>>I like the idea of having an inlined function (like >>>usb_fill_control_urb), to be sure that all manda

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-11 Thread Mauro Carvalho Chehab
Em 11-11-2010 21:40, Jarod Wilson escreveu: > On Thu, Nov 11, 2010 at 3:35 PM, David Härdeman wrote: >> On Thu, Nov 11, 2010 at 02:00:38PM -0200, Mauro Carvalho Chehab wrote: > ... struct input_dev only gets input_name, input_phys and input_id from struct rc_dev, and I did it that way be

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-11 Thread Jarod Wilson
On Thu, Nov 11, 2010 at 3:35 PM, David Härdeman wrote: > On Thu, Nov 11, 2010 at 02:00:38PM -0200, Mauro Carvalho Chehab wrote: ... >>> struct input_dev only gets input_name, input_phys and input_id from struct >>> rc_dev, and I did it that way because I didn't want to remove all that >>> informat

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-11 Thread David Härdeman
On Thu, Nov 11, 2010 at 02:00:38PM -0200, Mauro Carvalho Chehab wrote: >Em 11-11-2010 13:19, David Härdeman escreveu: >> On Thu, 11 Nov 2010 11:54:30 -0200, Mauro Carvalho Chehab >> wrote: >>> The bad news is that ir-kbd-i2c also needs the stuff that are inside >>> ir.props (e. g., the IR configur

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-11 Thread Mauro Carvalho Chehab
Em 11-11-2010 13:19, David Härdeman escreveu: > On Thu, 11 Nov 2010 11:54:30 -0200, Mauro Carvalho Chehab > wrote: >> The bad news is that ir-kbd-i2c also needs the stuff that are inside >> ir.props (e. g., the IR configuration logic). I wrote and just sent 2 >> patches to the ML with the fix patc

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-11 Thread David Härdeman
On Thu, 11 Nov 2010 11:54:30 -0200, Mauro Carvalho Chehab wrote: > The bad news is that ir-kbd-i2c also needs the stuff that are inside > ir.props (e. g., the IR configuration logic). I wrote and just sent 2 > patches to the ML with the fix patches, against my media-tree.git, > branch staging/for_

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-11 Thread Mauro Carvalho Chehab
Em 10-11-2010 20:01, David Härdeman escreveu: > On Wed, Nov 10, 2010 at 02:24:16PM -0200, Mauro Carvalho Chehab wrote: >> Em 10-11-2010 11:06, David Härdeman escreveu: >>> On Wed, 10 Nov 2010 10:49:10 -0200, Mauro Carvalho Chehab >>> wrote: >> So, I'll try to merge the pending patches from yo

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-11 Thread Mauro Carvalho Chehab
Em 10-11-2010 20:01, David Härdeman escreveu: > On Wed, Nov 10, 2010 at 02:24:16PM -0200, Mauro Carvalho Chehab wrote: >> Em 10-11-2010 11:06, David Härdeman escreveu: >>> On Wed, 10 Nov 2010 10:49:10 -0200, Mauro Carvalho Chehab >>> wrote: >> So, I'll try to merge the pending patches from yo

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-10 Thread David Härdeman
On Wed, Nov 10, 2010 at 02:24:16PM -0200, Mauro Carvalho Chehab wrote: > Em 10-11-2010 11:06, David Härdeman escreveu: > > On Wed, 10 Nov 2010 10:49:10 -0200, Mauro Carvalho Chehab > > wrote: > > >> So, I'll try to merge the pending patches from your tree. I'll let you > >> know if I have any pro

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-10 Thread Mauro Carvalho Chehab
Em 10-11-2010 11:06, David Härdeman escreveu: > On Wed, 10 Nov 2010 10:49:10 -0200, Mauro Carvalho Chehab > wrote: >> So, I'll try to merge the pending patches from your tree. I'll let you >> know if I have any problems. > > Sounds good. Thanks. David/Jarod, I pushed the merged patches at the

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-10 Thread David Härdeman
On Wed, 10 Nov 2010 10:49:10 -0200, Mauro Carvalho Chehab wrote: > Em 10-11-2010 07:24, David Härdeman escreveu: >> Not sure if you used the most recent version of patch 4/6 or not. >> >> If you used the most recent, it's based on 2.6.37-rc1 upstream which has >> both the large-input-scancodes pa

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-10 Thread Mauro Carvalho Chehab
Em 10-11-2010 07:24, David Härdeman escreveu: > On Tue, 09 Nov 2010 23:50:17 -0200, Mauro Carvalho Chehab > wrote: >> Hi David, >> >> Em 02-11-2010 18:26, Jarod Wilson escreveu: >>> On Tue, Nov 2, 2010 at 4:17 PM, David Härdeman >>> wrote: This is my current patch queue, the main change is t

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-10 Thread David Härdeman
On Tue, 9 Nov 2010 22:25:56 -0500, Jarod Wilson wrote: > On Tue, Nov 9, 2010 at 8:50 PM, Mauro Carvalho Chehab > wrote: > ... >> Sorry for giving you a late feedback about those patches. I was busy the >> last two >> weeks, due to my trip to US for KS/LPC. >> >> I've applied patches 1 to 3 (in fa

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-10 Thread David Härdeman
On Tue, 09 Nov 2010 23:50:17 -0200, Mauro Carvalho Chehab wrote: > Hi David, > > Em 02-11-2010 18:26, Jarod Wilson escreveu: >> On Tue, Nov 2, 2010 at 4:17 PM, David Härdeman >> wrote: >>> This is my current patch queue, the main change is to make struct rc_dev >>> the primary interface for rc d

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-09 Thread Mauro Carvalho Chehab
Em 10-11-2010 01:25, Jarod Wilson escreveu: > On Tue, Nov 9, 2010 at 8:50 PM, Mauro Carvalho Chehab > wrote: > ... >> Sorry for giving you a late feedback about those patches. I was busy the >> last two >> weeks, due to my trip to US for KS/LPC. >> >> I've applied patches 1 to 3 (in fact, I got t

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-09 Thread Jarod Wilson
On Tue, Nov 9, 2010 at 8:50 PM, Mauro Carvalho Chehab wrote: ... > Sorry for giving you a late feedback about those patches. I was busy the last > two > weeks, due to my trip to US for KS/LPC. > > I've applied patches 1 to 3 (in fact, I got the patches from the previous > version - > unfortunate

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-09 Thread Mauro Carvalho Chehab
Hi David, Em 02-11-2010 18:26, Jarod Wilson escreveu: > On Tue, Nov 2, 2010 at 4:17 PM, David Härdeman wrote: >> This is my current patch queue, the main change is to make struct rc_dev >> the primary interface for rc drivers and to abstract away the fact that >> there's an input device lurking i

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-09 Thread Mauro Carvalho Chehab
Hi David, Em 09-11-2010 08:27, David Härdeman escreveu: > On Tue, 02 Nov 2010 21:17:38 +0100, David Härdeman > wrote: >> This is my current patch queue, the main change is to make struct rc_dev >> the primary interface for rc drivers and to abstract away the fact that >> there's an input device l

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-09 Thread David Härdeman
On Tue, 02 Nov 2010 21:17:38 +0100, David Härdeman wrote: > This is my current patch queue, the main change is to make struct rc_dev > the primary interface for rc drivers and to abstract away the fact that > there's an input device lurking in there somewhere. Mauro, you have neither commented o

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-02 Thread Jarod Wilson
On Tue, Nov 2, 2010 at 4:17 PM, David Härdeman wrote: > This is my current patch queue, the main change is to make struct rc_dev > the primary interface for rc drivers and to abstract away the fact that > there's an input device lurking in there somewhere. > > In addition, the cx88 and winbond-cir

[PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-02 Thread David Härdeman
This is my current patch queue, the main change is to make struct rc_dev the primary interface for rc drivers and to abstract away the fact that there's an input device lurking in there somewhere. In addition, the cx88 and winbond-cir drivers are converted to use rc-core. The patchset is now base