Re: [PATCH 0/6] get rid of on-stack dma buffers

2011-03-22 Thread David Miller
From: James Bottomley Date: Tue, 22 Mar 2011 08:35:04 -0500 > The API will round up so that the correct region covers the API. > However, if you have other structures packed into the space (as very > often happens on stack), you get cache line interference in the CPU if > they get accessed: The

Re: [PATCH 0/6] get rid of on-stack dma buffers

2011-03-22 Thread Florian Mickler
2011/3/22 Roedel, Joerg : > On Mon, Mar 21, 2011 at 05:03:15PM -0400, Florian Mickler wrote: >> I guess (not verified), that the dma api takes sufficient precautions >> to abort the dma transfer if a timeout happens.  So freeing _should_ >> not be an issue. (At least, I would expect big fat warning

Re: [PATCH 0/6] get rid of on-stack dma buffers

2011-03-22 Thread Florian Mickler
2011/3/22 James Bottomley : > On Mon, 2011-03-21 at 22:03 +0100, Florian Mickler wrote: >> On Mon, 21 Mar 2011 15:26:43 -0400 >> Andy Walls wrote: >> >> > Florian Mickler wrote: >> >> To be blunt, I'm not shure I fully understand the requirements myself. >> But as far as I grasped it, the main pr

Re: [PATCH 0/6] get rid of on-stack dma buffers

2011-03-22 Thread James Bottomley
On Mon, 2011-03-21 at 22:03 +0100, Florian Mickler wrote: > On Mon, 21 Mar 2011 15:26:43 -0400 > Andy Walls wrote: > > > Florian Mickler wrote: > > > > >Hi all! > > > > > >These patches get rid of on-stack dma buffers for some of the dvb-usb > > >drivers. > > >I do not own the hardware, so the

Re: [PATCH 0/6] get rid of on-stack dma buffers

2011-03-22 Thread Johannes Stezenbach
On Tue, Mar 22, 2011 at 11:59:32AM +0100, Jiri Kosina wrote: > On Mon, 21 Mar 2011, Florian Mickler wrote: > > > To be blunt, I'm not shure I fully understand the requirements myself. > > But as far as I grasped it, the main problem is that we need memory > > which the processor can see as soon

Re: [PATCH 0/6] get rid of on-stack dma buffers

2011-03-22 Thread Oliver Neukum
Am Dienstag, 22. März 2011, 14:08:17 schrieb Florian Mickler: > Am 22.03.2011 12:10 schrieb "Roedel, Joerg" : > > > > On Mon, Mar 21, 2011 at 05:03:15PM -0400, Florian Mickler wrote: > > > I guess (not verified), that the dma api takes sufficient precautions > > > to abort the dma transfer if a tim

Re: [PATCH 0/6] get rid of on-stack dma buffers

2011-03-22 Thread Jiri Kosina
On Mon, 21 Mar 2011, Florian Mickler wrote: > To be blunt, I'm not shure I fully understand the requirements myself. > But as far as I grasped it, the main problem is that we need memory > which the processor can see as soon as the device has scribbled upon it. > (think caches and the like) >

Re: [PATCH 0/6] get rid of on-stack dma buffers

2011-03-22 Thread Roedel, Joerg
On Mon, Mar 21, 2011 at 05:03:15PM -0400, Florian Mickler wrote: > I guess (not verified), that the dma api takes sufficient precautions > to abort the dma transfer if a timeout happens. So freeing _should_ > not be an issue. (At least, I would expect big fat warnings everywhere > if that were the

Re: [PATCH 0/6] get rid of on-stack dma buffers

2011-03-21 Thread Florian Mickler
On Mon, 21 Mar 2011 15:26:43 -0400 Andy Walls wrote: > Florian Mickler wrote: > > >Hi all! > > > >These patches get rid of on-stack dma buffers for some of the dvb-usb > >drivers. > >I do not own the hardware, so these are only compile tested. I would > >appreciate testing and review. > >They

Re: [PATCH 0/6] get rid of on-stack dma buffers

2011-03-21 Thread Andy Walls
Florian Mickler wrote: >Hi all! > >These patches get rid of on-stack dma buffers for some of the dvb-usb >drivers. >I do not own the hardware, so these are only compile tested. I would >appreciate testing and review. >They were previously sent to the list, but some error on my side >prevented (

[PATCH 0/6] get rid of on-stack dma buffers

2011-03-21 Thread Florian Mickler
Hi all! These patches get rid of on-stack dma buffers for some of the dvb-usb drivers. I do not own the hardware, so these are only compile tested. I would appreciate testing and review. They were previously sent to the list, but some error on my side prevented (some of?) them from beeing delive