Re: [Mjpeg-users] [PATCH] zoran: invalid test on unsigned

2009-04-27 Thread Trent Piepho
On Mon, 27 Apr 2009, Alan Cox wrote: > On Sun, 26 Apr 2009 17:45:07 +0200 > Roel Kluin wrote: > > fmt->index is unsigned. test doesn't work > > > > Signed-off-by: Roel Kluin > > --- > > Is there another test required? > > > > +++ b/drivers/media/video/zoran/zoran_driver.c > > @@ -1871,7 +1871,7 @

Re: [Mjpeg-users] [PATCH] zoran: invalid test on unsigned

2009-04-27 Thread Alan Cox
On Sun, 26 Apr 2009 17:45:07 +0200 Roel Kluin wrote: > fmt->index is unsigned. test doesn't work > > Signed-off-by: Roel Kluin > --- > Is there another test required? > > diff --git a/drivers/media/video/zoran/zoran_driver.c > b/drivers/media/video/zoran/zoran_driver.c > index 092333b..0db5d0

Re: [PATCH] zoran: invalid test on unsigned

2009-04-26 Thread Trent Piepho
On Sun, 26 Apr 2009, Roel Kluin wrote: > fmt->index is unsigned. test doesn't work > > Signed-off-by: Roel Kluin > --- > Is there another test required? This is an old driver and I think back in v4l1 the indexes weren't all unsigned. There were a number of tests like this in it. Patch is fine.

[PATCH] zoran: invalid test on unsigned

2009-04-26 Thread Roel Kluin
fmt->index is unsigned. test doesn't work Signed-off-by: Roel Kluin --- Is there another test required? diff --git a/drivers/media/video/zoran/zoran_driver.c b/drivers/media/video/zoran/zoran_driver.c index 092333b..0db5d0f 100644 --- a/drivers/media/video/zoran/zoran_driver.c +++ b/drivers/med