Re: [PATCH] video: mx3_camera: Allocate camera object via kzalloc

2012-03-20 Thread Guennadi Liakhovetski
On Tue, 20 Mar 2012, Fabio Estevam wrote: > On 3/20/12, Guennadi Liakhovetski wrote: > > >> Is this valid only for mx3_camera driver? > > > > No > > > >> All other soc camera drivers use kzalloc. > >> > >> What makes mx3_camera different in this respect? > > > > Nothing > > Ok, so isn't my patc

Re: [PATCH] video: mx3_camera: Allocate camera object via kzalloc

2012-03-20 Thread Mauro Carvalho Chehab
Em 20-03-2012 04:57, Guennadi Liakhovetski escreveu: > On Mon, 19 Mar 2012, Mauro Carvalho Chehab wrote: > >> Em 20-02-2012 16:23, Fabio Estevam escreveu: >>> On Mon, Feb 20, 2012 at 4:17 PM, Guennadi Liakhovetski >>> wrote: On Mon, 20 Feb 2012, Fabio Estevam wrote: > Align mx3_came

Re: [PATCH] video: mx3_camera: Allocate camera object via kzalloc

2012-03-20 Thread Fabio Estevam
On 3/20/12, Guennadi Liakhovetski wrote: >> Is this valid only for mx3_camera driver? > > No > >> All other soc camera drivers use kzalloc. >> >> What makes mx3_camera different in this respect? > > Nothing Ok, so isn't my patch correct then? -- To unsubscribe from this list: send the line "unsu

Re: [PATCH] video: mx3_camera: Allocate camera object via kzalloc

2012-03-20 Thread Guennadi Liakhovetski
On Tue, 20 Mar 2012, Fabio Estevam wrote: > Hi Guennadi, > > On 3/20/12, Guennadi Liakhovetski wrote: > > > Don't think so. vzalloc() is used in mx3_camera to allocate driver private > > data objects and are never used for DMA, so, it doesn't have any > > restrictions on contiguity, coherency,

Re: [PATCH] video: mx3_camera: Allocate camera object via kzalloc

2012-03-20 Thread Fabio Estevam
Hi Guennadi, On 3/20/12, Guennadi Liakhovetski wrote: > Don't think so. vzalloc() is used in mx3_camera to allocate driver private > data objects and are never used for DMA, so, it doesn't have any > restrictions on contiguity, coherency, alignment etc. Is this valid only for mx3_camera driver?

Re: [PATCH] video: mx3_camera: Allocate camera object via kzalloc

2012-03-20 Thread Guennadi Liakhovetski
On Mon, 19 Mar 2012, Mauro Carvalho Chehab wrote: > Em 20-02-2012 16:23, Fabio Estevam escreveu: > > On Mon, Feb 20, 2012 at 4:17 PM, Guennadi Liakhovetski > > wrote: > >> On Mon, 20 Feb 2012, Fabio Estevam wrote: > >> > >>> Align mx3_camera driver with the other soc camera driver implementations

Re: [PATCH] video: mx3_camera: Allocate camera object via kzalloc

2012-03-19 Thread Mauro Carvalho Chehab
Em 20-02-2012 16:23, Fabio Estevam escreveu: > On Mon, Feb 20, 2012 at 4:17 PM, Guennadi Liakhovetski > wrote: >> On Mon, 20 Feb 2012, Fabio Estevam wrote: >> >>> Align mx3_camera driver with the other soc camera driver implementations >>> by allocating the camera object via kzalloc. >> >> Sorry,

Re: [PATCH] video: mx3_camera: Allocate camera object via kzalloc

2012-02-20 Thread Fabio Estevam
On Mon, Feb 20, 2012 at 4:17 PM, Guennadi Liakhovetski wrote: > On Mon, 20 Feb 2012, Fabio Estevam wrote: > >> Align mx3_camera driver with the other soc camera driver implementations >> by allocating the camera object via kzalloc. > > Sorry, any specific reason, why you think this "aligning" is s

Re: [PATCH] video: mx3_camera: Allocate camera object via kzalloc

2012-02-20 Thread Guennadi Liakhovetski
On Mon, 20 Feb 2012, Fabio Estevam wrote: > Align mx3_camera driver with the other soc camera driver implementations > by allocating the camera object via kzalloc. Sorry, any specific reason, why you think this "aligning" is so important? I personally don't see any. Thanks Guennadi > > Signed

[PATCH] video: mx3_camera: Allocate camera object via kzalloc

2012-02-20 Thread Fabio Estevam
Align mx3_camera driver with the other soc camera driver implementations by allocating the camera object via kzalloc. Signed-off-by: Fabio Estevam --- drivers/media/video/mx3_camera.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/mx3_camera.c b/dri