Re: [PATCH] vb2: V4L2_BUF_FLAG_DONE is set after DQBUF

2016-06-20 Thread Hans Verkuil
On 06/20/2016 12:12 PM, Ricardo Ribalda Delgado wrote: > Good catch :) > > I will prepare the new version. Btw, can I also merge > vb2_internal_dqbuf and vb2_dqbuf in one function? Seems a bit > overkilled that split. No, that's not possible. vb2_internal_dqbuf is used in the threading code to im

Re: [PATCH] vb2: V4L2_BUF_FLAG_DONE is set after DQBUF

2016-06-20 Thread Ricardo Ribalda Delgado
Good catch :) I will prepare the new version. Btw, can I also merge vb2_internal_dqbuf and vb2_dqbuf in one function? Seems a bit overkilled that split. Regarding v42l_compliance... I can take care of that if you dare :) Best regards! On Mon, Jun 20, 2016 at 11:53 AM, Hans Verkuil wrote: > On

Re: [PATCH] vb2: V4L2_BUF_FLAG_DONE is set after DQBUF

2016-06-20 Thread Hans Verkuil
On 06/20/2016 11:01 AM, Ricardo Ribalda Delgado wrote: > According to the doc, V4L2_BUF_FLAG_DONE is cleared after DQBUF: > > V4L2_BUF_FLAG_DONE 0x0004 ... After calling the VIDIOC_QBUF or > VIDIOC_DQBUF it is always cleared ... > > Unfortunately, it seems that videobuf2 keeps it set after D

[PATCH] vb2: V4L2_BUF_FLAG_DONE is set after DQBUF

2016-06-20 Thread Ricardo Ribalda Delgado
According to the doc, V4L2_BUF_FLAG_DONE is cleared after DQBUF: V4L2_BUF_FLAG_DONE 0x0004 ... After calling the VIDIOC_QBUF or VIDIOC_DQBUF it is always cleared ... Unfortunately, it seems that videobuf2 keeps it set after DQBUF. This can be tested with vivid and dev_debug: [257604.338082]