Re: [PATCH] vb2: Update buffer state flags after __vb2_dqbuf

2014-04-17 Thread Hans Verkuil
On 04/16/2014 09:34 PM, Nicolas Dufresne wrote: > > Previously we where updating the buffer state using __fill_v4l2_buffer > before the state transition was completed through __vb2_dqbuf. This > would cause the V4L2_BUF_FLAG_DONE to be set, which would mean it still > queued. The spec says the dqb

Re: [PATCH] vb2: Update buffer state flags after __vb2_dqbuf

2014-04-17 Thread Laurent Pinchart
Hi Nicolas, On Wednesday 16 April 2014 15:34:06 Nicolas Dufresne wrote: > Previously we where updating the buffer state using __fill_v4l2_buffer > before the state transition was completed through __vb2_dqbuf. This > would cause the V4L2_BUF_FLAG_DONE to be set, which would mean it still > queued.

[PATCH] vb2: Update buffer state flags after __vb2_dqbuf

2014-04-16 Thread Nicolas Dufresne
Previously we where updating the buffer state using __fill_v4l2_buffer before the state transition was completed through __vb2_dqbuf. This would cause the V4L2_BUF_FLAG_DONE to be set, which would mean it still queued. The spec says the dqbuf should clean the DONE flag, right not it alway set it.