Re: [PATCH] v4l2-mem2mem: add name argument to v4l2_m2m_register_media_controller()

2018-06-29 Thread Hans Verkuil
On 06/29/2018 09:01 AM, Hans Verkuil wrote: > Hi Ezequiel, > > I added support for this to a codec and I discovered that we are missing a > 'name' > argument to v4l2_m2m_register_media_controller(): a typical codec driver has > two > m2m video nodes: one for encoding, one for decoding. That work

[PATCH] v4l2-mem2mem: add name argument to v4l2_m2m_register_media_controller()

2018-06-29 Thread Hans Verkuil
Hi Ezequiel, I added support for this to a codec and I discovered that we are missing a 'name' argument to v4l2_m2m_register_media_controller(): a typical codec driver has two m2m video nodes: one for encoding, one for decoding. That works fine, except that the names of the source, sink and proc

Re: [PATCH] v4l2-mem2mem: drop lock in v4l2_m2m_fop_mmap

2015-07-20 Thread Mikhail Ulyanov
Hi Hans, 2015-07-20 10:58 GMT+03:00 Hans Verkuil : > > Since vb2_fop_mmap doesn't take the lock, neither should v4l2_m2m_fop_mmap. > > Signed-off-by: Hans Verkuil [snip] Tested-by: Mikhail Ulyanov -- W.B.R, Mikhail. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in

[PATCH] v4l2-mem2mem: drop lock in v4l2_m2m_fop_mmap

2015-07-20 Thread Hans Verkuil
The v4l2_m2m_fop_mmap function takes the core mutex, but this will result in a potential circular locking dependency: [ 262.517164] == [ 262.517166] [ INFO: possible circular locking dependency detected ] [ 262.517169] 4.2.0-rc2-koryphon #844

[PATCH] v4l2-mem2mem: no need to initialize b in v4l2_m2m_next_buf and v4l2_m2m_buf_remove

2015-03-11 Thread Philipp Zabel
The first time b is used, it is assigned to the first element of the rdy_queue list. There is no need to set it to NULL before. Signed-off-by: Philipp Zabel --- drivers/media/v4l2-core/v4l2-mem2mem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/

[PATCH] v4l2 mem2mem

2012-08-31 Thread Sascha Hauer
Two small patches, one fix and one more or less cosmetic patch for the v4l2 mem2mem framework. Comments welcome. Thanks, Sascha Sascha Hauer (2): media v4l2-mem2mem: Use list_first_entry media v4l2-mem2mem: fix src/out