Re: [PATCH] v4l2-compat-ioctl32: fix struct v4l2_event32 alignment

2015-08-21 Thread Hans Verkuil
On 08/21/2015 02:03 PM, Andrzej Hajda wrote: > Union v4l2_event::u is aligned to 8 bytes on arm32. On arm64 v4l2_event32::u > is aligned to 4 bytes. As a result structures v4l2_event and v4l2_event32 have > different sizes and VIDOC_DQEVENT ioctl does not work from arm32 apps running > on arm64 ker

[PATCH] v4l2-compat-ioctl32: fix struct v4l2_event32 alignment

2015-08-21 Thread Andrzej Hajda
Union v4l2_event::u is aligned to 8 bytes on arm32. On arm64 v4l2_event32::u is aligned to 4 bytes. As a result structures v4l2_event and v4l2_event32 have different sizes and VIDOC_DQEVENT ioctl does not work from arm32 apps running on arm64 kernel. The patch fixes it. Using compat_s64 allows to r

Re: [RFC PATCH] v4l2-compat-ioctl32: fix struct v4l2_event32 alignment

2015-08-21 Thread Hans Verkuil
On 08/21/2015 11:50 AM, Andrzej Hajda wrote: > Union v4l2_event::u is aligned to 8 bytes on arm32. On arm64 v4l2_event32::u > is aligned to 4 bytes. As a result structures v4l2_event and v4l2_event32 have > different sizes and VIDOC_DQEVENT ioctl does not work from arm32 apps running > on arm64 ker

[RFC PATCH] v4l2-compat-ioctl32: fix struct v4l2_event32 alignment

2015-08-21 Thread Andrzej Hajda
Union v4l2_event::u is aligned to 8 bytes on arm32. On arm64 v4l2_event32::u is aligned to 4 bytes. As a result structures v4l2_event and v4l2_event32 have different sizes and VIDOC_DQEVENT ioctl does not work from arm32 apps running on arm64 kernel. The patch fixes it. Signed-off-by: Andrzej Hajd