Re: [PATCH] v4l: Add driver for Micron MT9M032 camera sensor

2011-02-08 Thread Laurent Pinchart
Hi Martin, On Monday 24 January 2011 21:45:39 mar...@neutronstar.dyndns.org wrote: > On Mon, Jan 24, 2011 at 12:32:12PM +0100, Laurent Pinchart wrote: > > On Thursday 20 January 2011 23:56:07 mar...@neutronstar.dyndns.org wrote: [snip] > > > >> +#define OFFSET_UNCHANGED 0x > > > >>

Re: [PATCH] v4l: Add driver for Micron MT9M032 camera sensor

2011-01-24 Thread martin
On Mon, Jan 24, 2011 at 12:32:12PM +0100, Laurent Pinchart wrote: > Hi Martin, > > On Thursday 20 January 2011 23:56:07 mar...@neutronstar.dyndns.org wrote: > > [snip] > > > >> +static unsigned long mt9m032_row_time(struct mt9m032 *sensor, int > > >> width) +{ > > >> +int effective_width

Re: [PATCH] v4l: Add driver for Micron MT9M032 camera sensor

2011-01-24 Thread Laurent Pinchart
Hi Martin, On Thursday 20 January 2011 23:56:07 mar...@neutronstar.dyndns.org wrote: [snip] > >> +static unsigned long mt9m032_row_time(struct mt9m032 *sensor, int > >> width) +{ > >> + int effective_width; > >> + u64 ns; > >> + effective_width = width + 716; /* emperical value */ > > > > Wh

Re: [PATCH] v4l: Add driver for Micron MT9M032 camera sensor

2011-01-24 Thread Laurent Pinchart
Hi Martin, On Wednesday 19 January 2011 20:12:14 mar...@neutronstar.dyndns.org wrote: > On Wed, Jan 19, 2011 at 12:05:10AM +0100, Hans Verkuil wrote: > > On Tuesday, January 18, 2011 23:18:42 Martin Hostettler wrote: [snip] > > > +#ifdef CONFIG_VIDEO_ADV_DEBUG > > > +static long mt9m032_ioctl(st

Re: [PATCH] v4l: Add driver for Micron MT9M032 camera sensor

2011-01-24 Thread Laurent Pinchart
Hi Hans, On Wednesday 19 January 2011 08:23:18 Hans Verkuil wrote: > On Wednesday, January 19, 2011 00:50:35 Laurent Pinchart wrote: > > On Wednesday 19 January 2011 00:05:10 Hans Verkuil wrote: > > > On Tuesday, January 18, 2011 23:18:42 Martin Hostettler wrote: [snip] > > > > +#ifdef CONFIG_VI

Re: [PATCH] v4l: Add driver for Micron MT9M032 camera sensor

2011-01-20 Thread martin
Hi Laurent, >> + >> +#define MT9M032_CHIP_VERSION0x00 >> +#define MT9M032_ROW_START 0x01 >> +#define MT9M032_COLUMN_START0x02 >> +#define MT9M032_ROW_SIZE0x03 >> +#define MT9M032_COLUMN_SIZE 0x04 >> +#define MT9M032_HBLANK

Re: [PATCH] v4l: Add driver for Micron MT9M032 camera sensor

2011-01-19 Thread martin
Hi Hans, Thanks for the quick review. I just noticed i didn't really understand the new control framework that well, could you maybe add a comment pointing to Documentation/video4linux/v4l2-controls.txt in the v4l2-ctrl.h header? I think that would help a lot. On Wed, Jan 19, 2011 at 12:05:1

Re: [PATCH] v4l: Add driver for Micron MT9M032 camera sensor

2011-01-18 Thread Hans Verkuil
On Wednesday, January 19, 2011 00:50:35 Laurent Pinchart wrote: > Hi Hans and Martin, > > On Wednesday 19 January 2011 00:05:10 Hans Verkuil wrote: > > On Tuesday, January 18, 2011 23:18:42 Martin Hostettler wrote: > > [snip] > > > > + return mt9m032_write_reg(client, MT9M032_VBLANK, > > > addit

Re: [PATCH] v4l: Add driver for Micron MT9M032 camera sensor

2011-01-18 Thread Laurent Pinchart
Hi Martin, Thanks for the patch. On Tuesday 18 January 2011 23:18:42 Martin Hostettler wrote: > The MT9M032 is a parallel 1284x812 sensor from Micron controlled through > I2C. > > The driver creates a V4L2 subdevice. It currently supports cropping, gain, > exposure and v/h flipping controls in m

Re: [PATCH] v4l: Add driver for Micron MT9M032 camera sensor

2011-01-18 Thread Laurent Pinchart
Hi Hans and Martin, On Wednesday 19 January 2011 00:05:10 Hans Verkuil wrote: > On Tuesday, January 18, 2011 23:18:42 Martin Hostettler wrote: [snip] > > + return mt9m032_write_reg(client, MT9M032_VBLANK, > > additional_blanking_rows); > > I've found it easier to do the v4l2_subdev to i2c_cli

Re: [PATCH] v4l: Add driver for Micron MT9M032 camera sensor

2011-01-18 Thread Hans Verkuil
Hi Martin, On Tuesday, January 18, 2011 23:18:42 Martin Hostettler wrote: > The MT9M032 is a parallel 1284x812 sensor from Micron controlled through I2C. > > The driver creates a V4L2 subdevice. It currently supports cropping, gain, > exposure and v/h flipping controls in monochrome mode with an

[PATCH] v4l: Add driver for Micron MT9M032 camera sensor

2011-01-18 Thread Martin Hostettler
The MT9M032 is a parallel 1284x812 sensor from Micron controlled through I2C. The driver creates a V4L2 subdevice. It currently supports cropping, gain, exposure and v/h flipping controls in monochrome mode with an external pixel clock. Signed-off-by: Martin Hostettler --- drivers/media/video/K