Re: [PATCH] tuners: tda8290: reduce stack usage with kasan

2017-12-12 Thread Joe Perches
On Tue, 2017-12-12 at 15:21 +0100, Arnd Bergmann wrote: > On Tue, Dec 12, 2017 at 1:45 PM, Mauro Carvalho Chehab > wrote: > > Em Tue, 12 Dec 2017 03:42:32 -0800 > > Joe Perches escreveu: > > > > > > I actually thought about marking them 'const' here before sending > > > > (without noticing the c

Re: [PATCH] tuners: tda8290: reduce stack usage with kasan

2017-12-12 Thread Arnd Bergmann
On Tue, Dec 12, 2017 at 1:45 PM, Mauro Carvalho Chehab wrote: > Em Tue, 12 Dec 2017 03:42:32 -0800 > Joe Perches escreveu: > >> > I actually thought about marking them 'const' here before sending >> > (without noticing the changelog text) and then ran into what must >> > have led me to drop the '

Re: [PATCH] tuners: tda8290: reduce stack usage with kasan

2017-12-12 Thread Mauro Carvalho Chehab
Em Tue, 12 Dec 2017 03:42:32 -0800 Joe Perches escreveu: > > I actually thought about marking them 'const' here before sending > > (without noticing the changelog text) and then ran into what must > > have led me to drop the 'const' originally: tuner_i2c_xfer_send() > > takes a non-const pointer.

Re: [PATCH] tuners: tda8290: reduce stack usage with kasan

2017-12-12 Thread Joe Perches
On Tue, 2017-12-12 at 11:24 +0100, Arnd Bergmann wrote: > On Mon, Dec 11, 2017 at 10:17 PM, Michael Ira Krufky > wrote: > > On Mon, Dec 11, 2017 at 2:34 PM, Joe Perches wrote: > > > On Mon, 2017-12-11 at 13:06 +0100, Arnd Bergmann wrote: > > > > With CONFIG_KASAN enabled, we get a relatively larg

Re: [PATCH] tuners: tda8290: reduce stack usage with kasan

2017-12-12 Thread Arnd Bergmann
On Mon, Dec 11, 2017 at 10:17 PM, Michael Ira Krufky wrote: > On Mon, Dec 11, 2017 at 2:34 PM, Joe Perches wrote: >> On Mon, 2017-12-11 at 13:06 +0100, Arnd Bergmann wrote: >>> With CONFIG_KASAN enabled, we get a relatively large stack frame in one >>> function >>> >>> drivers/media/tuners/tda82

Re: [PATCH] tuners: tda8290: reduce stack usage with kasan

2017-12-11 Thread Michael Ira Krufky
On Mon, Dec 11, 2017 at 2:34 PM, Joe Perches wrote: > On Mon, 2017-12-11 at 13:06 +0100, Arnd Bergmann wrote: >> With CONFIG_KASAN enabled, we get a relatively large stack frame in one >> function >> >> drivers/media/tuners/tda8290.c: In function 'tda8290_set_params': >> drivers/media/tuners/tda8

Re: [PATCH] tuners: tda8290: reduce stack usage with kasan

2017-12-11 Thread Joe Perches
On Mon, 2017-12-11 at 13:06 +0100, Arnd Bergmann wrote: > With CONFIG_KASAN enabled, we get a relatively large stack frame in one > function > > drivers/media/tuners/tda8290.c: In function 'tda8290_set_params': > drivers/media/tuners/tda8290.c:310:1: warning: the frame size of 1520 bytes > is la

Re: [PATCH] tuners: tda8290: reduce stack usage with kasan

2017-12-11 Thread Michael Ira Krufky
On Mon, Dec 11, 2017 at 7:06 AM, Arnd Bergmann wrote: > With CONFIG_KASAN enabled, we get a relatively large stack frame in one > function > > drivers/media/tuners/tda8290.c: In function 'tda8290_set_params': > drivers/media/tuners/tda8290.c:310:1: warning: the frame size of 1520 bytes > is larg

[PATCH] tuners: tda8290: reduce stack usage with kasan

2017-12-11 Thread Arnd Bergmann
With CONFIG_KASAN enabled, we get a relatively large stack frame in one function drivers/media/tuners/tda8290.c: In function 'tda8290_set_params': drivers/media/tuners/tda8290.c:310:1: warning: the frame size of 1520 bytes is larger than 1024 bytes [-Wframe-larger-than=] With CONFIG_KASAN_EXTRA