Re: [PATCH] soc-camera: tw9910: Add sync polarity support

2009-11-23 Thread Kuninori Morimoto
Dear Guennadi > > -#define HSP_LOW 0x00 /* 0 : HS pin output polarity is active low */ > > +#define HSP_LO 0x00 /* 0 : HS pin output polarity is active low */ > > I would remove field names with "0" values completely. Also see below (snip) > > +#define VSP_V_LOVSP_HI /* xSSL_xVALID

Re: [PATCH] soc-camera: tw9910: Add sync polarity support

2009-11-20 Thread Guennadi Liakhovetski
On Fri, 20 Nov 2009, Kuninori Morimoto wrote: > Signed-off-by: Kuninori Morimoto > --- > drivers/media/video/tw9910.c | 22 +++--- > 1 files changed, 19 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/video/tw9910.c b/drivers/media/video/tw9910.c > index a4ba720..

[PATCH] soc-camera: tw9910: Add sync polarity support

2009-11-19 Thread Kuninori Morimoto
Signed-off-by: Kuninori Morimoto --- drivers/media/video/tw9910.c | 22 +++--- 1 files changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/tw9910.c b/drivers/media/video/tw9910.c index a4ba720..243207d 100644 --- a/drivers/media/video/tw9910.c +++ b/drive