Re: [PATCH] sn9c20x: Reduce data usage, make functions static

2009-09-04 Thread Brian Johnson
Jean-Francois, The two red tables actually do contain values greater then 127 so would not fit within a s8 variable, the other four i think may have only values between -128 and 127 but i haven't gone through and made sure of that. Brian On Fri, Sep 4, 2009 at 5:24 AM, Jean-Francois Moine wrote:

Re: [PATCH] sn9c20x: Reduce data usage, make functions static

2009-09-04 Thread Jean-Francois Moine
On Thu, 20 Aug 2009 19:08:58 -0700 Joe Perches wrote: > Compiled, not tested, no hardware > > Reduces size of object > > Use s16 instead of int where possible. [snip] > -static const int hsv_red_x[] = { > +static const s16 hsv_red_x[] = { > 41, 44, 46, 48, 50, 52, 54, 56, >

Re: [PATCH] sn9c20x: Reduce data usage, make functions static

2009-08-31 Thread Brian Johnson
Mauro, Yes, sorry been busy this last week. I've tested this patch against three separate webcams and everything works just fine. I'd also like to ask if it would be possible to get a mercurial account on linuxtv.org? Brian Johnson On Sun, Aug 30, 2009 at 10:24 PM, Mauro Carvalho Chehab wrote: >

Re: [PATCH] sn9c20x: Reduce data usage, make functions static

2009-08-30 Thread Mauro Carvalho Chehab
Hi Brian, Any news about the patch? It is always a good idea to try to reduce the kernel size footprint. Cheers, Mauro. Em Thu, 20 Aug 2009 19:08:58 -0700 Joe Perches escreveu: > Compiled, not tested, no hardware > > Reduces size of object > > Use s16 instead of int where possible. > Use str

[PATCH] sn9c20x: Reduce data usage, make functions static

2009-08-20 Thread Joe Perches
Compiled, not tested, no hardware Reduces size of object Use s16 instead of int where possible. Use struct instead of arrays Before: $ size drivers/media/video/gspca/sn9c20x.o textdata bss dec hex filename 2934611244128 345988726 drivers/media/video/gspca/sn9c2