Re: [PATCH] si2168: Fix unknown chip version message

2014-07-23 Thread Mauro Carvalho Chehab
Em Wed, 23 Jul 2014 11:22:40 +0300 Antti Palosaari escreveu: > Moikka! > It is single character formatter, not string, => no need to terminate, > so that patch is not valid. Well, what happened with an invalid firmware is that the first %c was a 0x00 character, causing that the \n at the end an

Re: [PATCH] si2168: Fix unknown chip version message

2014-07-23 Thread Antti Palosaari
Moikka! It is single character formatter, not string, => no need to terminate, so that patch is not valid. regards Antti On 07/22/2014 10:14 PM, Mauro Carvalho Chehab wrote: At least here with my PCTV 292e, it is printing this error: si2168 10-0064: si2168: unkown chip version Si211

[PATCH] si2168: Fix unknown chip version message

2014-07-22 Thread Mauro Carvalho Chehab
At least here with my PCTV 292e, it is printing this error: si2168 10-0064: si2168: unkown chip version Si21170- without a \n at the end. Probably because it is doing something weird or firmware didn't load well. Anyway, better to print it in hex, instead of using %c. While here, fix the