Re: [PATCH] s5p-fimc: Fix platform entities registration

2012-10-27 Thread Sylwester Nawrocki
On 10/25/2012 02:42 PM, Sylwester Nawrocki wrote: > Hi Laurent, > > On 10/25/2012 01:35 PM, Laurent Pinchart wrote: >> On Thursday 25 October 2012 11:06:56 Sylwester Nawrocki wrote: >>> Make sure there is no v4l2_device_unregister_subdev() call >>> on a subdev which wasn't registered. >> >> I'm no

[PATCH] s5p-fimc: Fix platform entities registration

2012-10-25 Thread Sylwester Nawrocki
Make sure the platform sub-devices are registered to the media device driver only when v4l2_device_unregister_subdev() succeeds. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 33 1 file changed, 16

Re: [PATCH] s5p-fimc: Fix platform entities registration

2012-10-25 Thread Sylwester Nawrocki
Hi Laurent, On 10/25/2012 01:35 PM, Laurent Pinchart wrote: > On Thursday 25 October 2012 11:06:56 Sylwester Nawrocki wrote: >> Make sure there is no v4l2_device_unregister_subdev() call >> on a subdev which wasn't registered. > > I'm not implying that this fix is bad, but doesn't the V4L2 core a

Re: [PATCH] s5p-fimc: Fix platform entities registration

2012-10-25 Thread Laurent Pinchart
Hi Sylwester, On Thursday 25 October 2012 11:06:56 Sylwester Nawrocki wrote: > Make sure there is no v4l2_device_unregister_subdev() call > on a subdev which wasn't registered. I'm not implying that this fix is bad, but doesn't the V4L2 core already handle this ? v4l2_device_unregister_subdev()

[PATCH] s5p-fimc: Fix platform entities registration

2012-10-25 Thread Sylwester Nawrocki
Make sure there is no v4l2_device_unregister_subdev() call on a subdev which wasn't registered. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 25 1 file changed, 13 insertions(+), 12 deletions(-) d