Tobias Lorenz wrote:
> Hello Mauro,
>
>>> no, the default value of retval makes no difference to the function.
>>>
>>> Retval is set by si470x_disconnect_check and si470x_set_register.
>>> After each call, retval is checked.
>>> There is no need to reset it passed.
>
>> You may just do then:
>>
>
Hello Mauro,
> > no, the default value of retval makes no difference to the function.
> >
> > Retval is set by si470x_disconnect_check and si470x_set_register.
> > After each call, retval is checked.
> > There is no need to reset it passed.
> You may just do then:
>
> int retval = si470x_
Tobias Lorenz wrote:
> Hello Roel,
>
> no, the default value of retval makes no difference to the function.
>
> Retval is set by si470x_disconnect_check and si470x_set_register.
> After each call, retval is checked.
> There is no need to reset it passed.
>
> The only reason, there is a default v
Hello Roel,
no, the default value of retval makes no difference to the function.
Retval is set by si470x_disconnect_check and si470x_set_register.
After each call, retval is checked.
There is no need to reset it passed.
The only reason, there is a default value is my static code checker, saying
The -EINVAL was overwritten by the si470x_disconnect_check().
Signed-off-by: Roel Kluin
---
Is this needed?
diff --git a/drivers/media/radio/si470x/radio-si470x-common.c
b/drivers/media/radio/si470x/radio-si470x-common.c
index 4da0f15..65b4a92 100644
--- a/drivers/media/radio/si470x/radio-si470
