Re: [PATCH] ov772x: add edge contrl support

2009-03-23 Thread morimoto . kuninori
Dear Guennadi > Is edge_strength == 0 a useful edge configuration? Cannot you use it as a > test whether to set all edge parameters or not? If you cannot, well, just > do the same as what you have done with 32-bits - use one bit in strength > as "edge enable" - just exactly in the same way as

Re: [PATCH] ov772x: add edge contrl support

2009-03-23 Thread Guennadi Liakhovetski
On Mon, 23 Mar 2009, morimoto.kunin...@renesas.com wrote: > Dear Guennadi > > Thank you for checking > > > Wouldn't it be easier to use > > > > unsigned char edge_strength; > > unsigned char edge_threshold; > > unsigned char edge_low; > > unsigned char edge_high; > > >

Re: [PATCH] ov772x: add edge contrl support

2009-03-23 Thread morimoto . kuninori
Dear Guennadi Thank you for checking > Wouldn't it be easier to use > > unsigned char edge_strength; > unsigned char edge_threshold; > unsigned char edge_low; > unsigned char edge_high; > > and thus avoid all that shifting? Yes. it is easier to use. But, driver

Re: [PATCH] ov772x: add edge contrl support

2009-03-23 Thread Guennadi Liakhovetski
On Mon, 23 Mar 2009, Kuninori Morimoto wrote: > > Signed-off-by: Kuninori Morimoto > --- > This patch is 1st step for extra settings > > drivers/media/video/ov772x.c | 34 ++ > include/media/ov772x.h | 25 + > 2 files changed, 5

[PATCH] ov772x: add edge contrl support

2009-03-22 Thread Kuninori Morimoto
Signed-off-by: Kuninori Morimoto --- This patch is 1st step for extra settings drivers/media/video/ov772x.c | 34 ++ include/media/ov772x.h | 25 + 2 files changed, 59 insertions(+), 0 deletions(-) diff --git a/drivers/media/vid