Re: [PATCH] ov772x: Add extra setting method

2009-03-11 Thread morimoto . kuninori
Dear Guennadi Thank you for comment > Ok, this is indeed a lot, still, we should do this properly. After a > discussion with Hans on IRC the general conclusion was "noone outside of > the device driver shall even know device registers." I think, we shall > split this huge array in at least 3

Re: [PATCH] ov772x: Add extra setting method

2009-03-11 Thread Guennadi Liakhovetski
On Tue, 3 Mar 2009, morimoto.kunin...@renesas.com wrote: > > can be. For instance, maybe there are only two variants like > > lens-configuration-A and lens-configuration-B? Then I would just add > > respective flags to platform data. If there are really many variants, > > maybe we can let user-

Re: [PATCH] ov772x: Add extra setting method

2009-03-03 Thread morimoto . kuninori
Dear Guennadi > can be. For instance, maybe there are only two variants like > lens-configuration-A and lens-configuration-B? Then I would just add > respective flags to platform data. If there are really many variants, > maybe we can let user-space configure them using VIDIOC_DBG_S_REGISTER?

Re: [PATCH] ov772x: Add extra setting method

2009-03-03 Thread Guennadi Liakhovetski
On Tue, 3 Mar 2009, Kuninori Morimoto wrote: > This patch add support extra register settings for platform. > For instance, platform comes to be able to use the > special setting like lens. > > Signed-off-by: Kuninori Morimoto > --- [snip] > @@ -815,6 +808,14 @@ static int ov772x_set_params(stru

[PATCH] ov772x: Add extra setting method

2009-03-02 Thread Kuninori Morimoto
This patch add support extra register settings for platform. For instance, platform comes to be able to use the special setting like lens. Signed-off-by: Kuninori Morimoto --- Thank you Magnus for your nice comment. drivers/media/video/ov772x.c | 15 --- include/media/ov772x.h