soc-camera: two fixes (was Re: [PATCH] mx2_camera: fix pixel clock polarity configuration)

2010-12-07 Thread Guennadi Liakhovetski
Mauro Since you still haven't pulled my fixes branch, and I have one more fix, that I've posted a while ago but didn't commit to linuxtv.org. Can I now push it to the same 2.6.37-rc3-fixes branch for you to pull from? Thanks Guennadi On Thu, 2 Dec 2010, Guennadi Liakhovetski wrote: > On Thu,

Re: [PATCH] mx2_camera: fix pixel clock polarity configuration

2010-12-02 Thread Guennadi Liakhovetski
On Thu, 2 Dec 2010, Baruch Siach wrote: > Hi Guennadi, > > On Wed, Nov 17, 2010 at 08:09:09AM +0100, Guennadi Liakhovetski wrote: > > On Wed, 10 Nov 2010, Baruch Siach wrote: > > > Guennadi Liakhovetski gmx.de> writes: > > > > On Wed, 27 Oct 2010, Baruch Siach wrote: > > > > > When SOCAM_PCLK_SA

Re: [PATCH] mx2_camera: fix pixel clock polarity configuration

2010-12-02 Thread Baruch Siach
Hi Guennadi, On Wed, Nov 17, 2010 at 08:09:09AM +0100, Guennadi Liakhovetski wrote: > On Wed, 10 Nov 2010, Baruch Siach wrote: > > Guennadi Liakhovetski gmx.de> writes: > > > On Wed, 27 Oct 2010, Baruch Siach wrote: > > > > When SOCAM_PCLK_SAMPLE_FALLING, just leave CSICR1_REDGE unset, > > > > o

Re: [PATCH] mx2_camera: fix pixel clock polarity configuration

2010-11-16 Thread Guennadi Liakhovetski
On Wed, 10 Nov 2010, Baruch Siach wrote: > Guennadi Liakhovetski gmx.de> writes: > > > On Wed, 27 Oct 2010, Baruch Siach wrote: > > > When SOCAM_PCLK_SAMPLE_FALLING, just leave CSICR1_REDGE unset, > > > otherwise we get > > > the inverted behaviour. > > Seems logical to me, that if this is true

Re: [PATCH] mx2_camera: fix pixel clock polarity configuration

2010-11-10 Thread Baruch Siach
Guennadi Liakhovetski gmx.de> writes: > On Wed, 27 Oct 2010, Baruch Siach wrote: > > When SOCAM_PCLK_SAMPLE_FALLING, just leave CSICR1_REDGE unset, > > otherwise we get > > the inverted behaviour. > Seems logical to me, that if this is true, then you need the inverse: > > if (!(common_fla

Re: [PATCH] mx2_camera: fix pixel clock polarity configuration

2010-11-10 Thread Guennadi Liakhovetski
On Wed, 10 Nov 2010, Baruch Siach wrote: > Hi linux-media, > > On Wed, Oct 27, 2010 at 09:03:52AM +0200, Baruch Siach wrote: > > When SOCAM_PCLK_SAMPLE_FALLING, just leave CSICR1_REDGE unset, otherwise we > > get > > the inverted behaviour. > > > > Signed-off-by: Baruch Siach > > Trying my lu

Re: [PATCH] mx2_camera: fix pixel clock polarity configuration

2010-11-10 Thread Baruch Siach
Hi linux-media, On Wed, Oct 27, 2010 at 09:03:52AM +0200, Baruch Siach wrote: > When SOCAM_PCLK_SAMPLE_FALLING, just leave CSICR1_REDGE unset, otherwise we > get > the inverted behaviour. > > Signed-off-by: Baruch Siach Trying my luck again. Now adding Guennadi to Cc. This is a real bug fix,

Re: [PATCH] mx2_camera: fix pixel clock polarity configuration

2010-10-27 Thread Guennadi Liakhovetski
On Wed, 27 Oct 2010, Baruch Siach wrote: > When SOCAM_PCLK_SAMPLE_FALLING, just leave CSICR1_REDGE unset, otherwise we > get > the inverted behaviour. Seems logical to me, that if this is true, then you need the inverse: if (!(common_flags & SOCAM_PCLK_SAMPLE_FALLING)) c

[PATCH] mx2_camera: fix pixel clock polarity configuration

2010-10-27 Thread Baruch Siach
When SOCAM_PCLK_SAMPLE_FALLING, just leave CSICR1_REDGE unset, otherwise we get the inverted behaviour. Signed-off-by: Baruch Siach --- drivers/media/video/mx2_camera.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/vide