Re: [PATCH] mt9p031: Really disable Black Level Calibration in test pattern mode

2014-05-08 Thread Laurent Pinchart
Hi Hans, On Thursday 08 May 2014 10:44:12 Hans Verkuil wrote: > Hi Laurent, > > The patch is correct, but I noticed a pre-existing bug that should be > fixed. See below. > > On 05/07/14 17:40, Laurent Pinchart wrote: > > The digital side of the Black Level Calibration (BLC) function must be > >

Re: [PATCH] mt9p031: Really disable Black Level Calibration in test pattern mode

2014-05-08 Thread Hans Verkuil
Hi Laurent, The patch is correct, but I noticed a pre-existing bug that should be fixed. See below. On 05/07/14 17:40, Laurent Pinchart wrote: > The digital side of the Black Level Calibration (BLC) function must be > disabled when generating a test pattern to avoid artifacts in the image. > The

[PATCH] mt9p031: Really disable Black Level Calibration in test pattern mode

2014-05-07 Thread Laurent Pinchart
The digital side of the Black Level Calibration (BLC) function must be disabled when generating a test pattern to avoid artifacts in the image. The driver disables BLC correctly at the hardware level, but the feature gets reenabled by v4l2_ctrl_handler_setup() the next time the device is powered on