Re: [PATCH] media_build: fix module_*_driver redefined warnings

2012-04-09 Thread Mauro Carvalho Chehab
Em 09-04-2012 11:15, Gianluca Gennari escreveu: > > Il 09/04/2012 14:34, Mauro Carvalho Chehab ha scritto: >> Hi Gianluca, >> >> Em 20-03-2012 11:10, Gianluca Gennari escreveu: >> >> Please avoid adding more tests for an specific Kernel version here. There are >> two issues with checks like that:

Re: [PATCH] media_build: fix module_*_driver redefined warnings

2012-04-09 Thread Gianluca Gennari
Il 09/04/2012 14:34, Mauro Carvalho Chehab ha scritto: > Hi Gianluca, > > Em 20-03-2012 11:10, Gianluca Gennari escreveu: > > Please avoid adding more tests for an specific Kernel version here. There are > two issues with checks like that: > > 1) this may break on some kernel-fix release

Re: [PATCH] media_build: fix module_*_driver redefined warnings

2012-04-09 Thread Mauro Carvalho Chehab
Hi Gianluca, Em 20-03-2012 11:10, Gianluca Gennari escreveu: > The conditions "#ifndef module_usb_driver" and "#ifndef > module_platform_driver" > are always true, as the header files where this macros are defined are not > included in compat.h (linux/usb.h and linux/platform_devices.h). > > Thi

[PATCH] media_build: fix module_*_driver redefined warnings

2012-03-20 Thread Gianluca Gennari
The conditions "#ifndef module_usb_driver" and "#ifndef module_platform_driver" are always true, as the header files where this macros are defined are not included in compat.h (linux/usb.h and linux/platform_devices.h). This produces a lot of warnings like "module_usb_driver redefined" or "module_