Re: [PATCH] media: vimc: embed the pads of entities in the entities' structs

2019-10-01 Thread Helen Koike
Hi Dafna, Thanks for your patch, just some comments below. On 10/1/19 2:07 PM, Dafna Hirschfeld wrote: > since the pads array is of known small size, there is no reason to > allocate it separately. Instead, it is embedded in the entity struct. > This also conforms to the media controller doc: > '

[PATCH] media: vimc: embed the pads of entities in the entities' structs

2019-10-01 Thread Dafna Hirschfeld
since the pads array is of known small size, there is no reason to allocate it separately. Instead, it is embedded in the entity struct. This also conforms to the media controller doc: 'Most drivers will embed the pads array in a driver-specific structure, avoiding dynamic allocation.' Signed-off-