Re: [PATCH] media: st-rc: Add ST remote control driver

2013-08-16 Thread Srinivas KANDAGATLA
On 16/08/13 12:40, Sean Young wrote: > On Fri, Aug 16, 2013 at 11:53:48AM +0100, Srinivas KANDAGATLA wrote: >> Thanks Sean for the comments. >> On 16/08/13 09:38, Sean Young wrote: >>> On Wed, Aug 14, 2013 at 06:27:01PM +0100, Srinivas KANDAGATLA wrote: >> [...] + /* discard t

Re: [PATCH] media: st-rc: Add ST remote control driver

2013-08-16 Thread Sean Young
On Fri, Aug 16, 2013 at 11:53:48AM +0100, Srinivas KANDAGATLA wrote: > Thanks Sean for the comments. > On 16/08/13 09:38, Sean Young wrote: > > On Wed, Aug 14, 2013 at 06:27:01PM +0100, Srinivas KANDAGATLA wrote: > [...] > >> + /* discard the entire collection in case of errors! *

Re: [PATCH] media: st-rc: Add ST remote control driver

2013-08-16 Thread Srinivas KANDAGATLA
Thanks Sean for the comments. On 16/08/13 09:38, Sean Young wrote: > On Wed, Aug 14, 2013 at 06:27:01PM +0100, Srinivas KANDAGATLA wrote: [...] >> >> Documentation/devicetree/bindings/media/st-rc.txt | 18 + >> drivers/media/rc/Kconfig | 10 + >> drivers/media/rc/Makef

Re: [PATCH] media: st-rc: Add ST remote control driver

2013-08-16 Thread Sean Young
On Wed, Aug 14, 2013 at 06:27:01PM +0100, Srinivas KANDAGATLA wrote: > From: Srinivas Kandagatla > > This patch adds support to ST RC driver, which is basically a IR/UHF > receiver and transmitter. This IP is common across all the ST parts for > settop box platforms. IRB is embedded in ST COMMS I

Re: [PATCH] media: st-rc: Add ST remote control driver

2013-08-15 Thread Mark Rutland
On Thu, Aug 15, 2013 at 03:06:14PM +0100, Srinivas KANDAGATLA wrote: > On 15/08/13 14:29, Mark Rutland wrote: > > On Thu, Aug 15, 2013 at 01:57:13PM +0100, Srinivas KANDAGATLA wrote: > >> Thanks Mark for your comments. > >> > >> On 15/08/13 09:49, Mark Rutland wrote: > >>> On Wed, Aug 14, 2013 at 0

Re: [PATCH] media: st-rc: Add ST remote control driver

2013-08-15 Thread Srinivas KANDAGATLA
On 15/08/13 14:29, Mark Rutland wrote: > On Thu, Aug 15, 2013 at 01:57:13PM +0100, Srinivas KANDAGATLA wrote: >> Thanks Mark for your comments. >> >> On 15/08/13 09:49, Mark Rutland wrote: >>> On Wed, Aug 14, 2013 at 06:27:01PM +0100, Srinivas KANDAGATLA wrote: From: Srinivas Kandagatla

Re: [PATCH] media: st-rc: Add ST remote control driver

2013-08-15 Thread Srinivas KANDAGATLA
On 15/08/13 14:30, Pawel Moll wrote: > On Wed, 2013-08-14 at 18:27 +0100, Srinivas KANDAGATLA wrote: >> +Device-Tree bindings for ST IR and UHF receiver >> + >> +Required properties: >> + - compatible: should be "st,rc". >> + - st,uhfmode: boolean property to indicate if reception is in

Re: [PATCH] media: st-rc: Add ST remote control driver

2013-08-15 Thread Pawel Moll
On Wed, 2013-08-14 at 18:27 +0100, Srinivas KANDAGATLA wrote: > +Device-Tree bindings for ST IR and UHF receiver > + > +Required properties: > + - compatible: should be "st,rc". > + - st,uhfmode: boolean property to indicate if reception is in UHF. > + - reg: base physical address

Re: [PATCH] media: st-rc: Add ST remote control driver

2013-08-15 Thread Mark Rutland
On Thu, Aug 15, 2013 at 01:57:13PM +0100, Srinivas KANDAGATLA wrote: > Thanks Mark for your comments. > > On 15/08/13 09:49, Mark Rutland wrote: > > On Wed, Aug 14, 2013 at 06:27:01PM +0100, Srinivas KANDAGATLA wrote: > >> From: Srinivas Kandagatla > >> > >> This patch adds support to ST RC drive

Re: [PATCH] media: st-rc: Add ST remote control driver

2013-08-15 Thread Srinivas KANDAGATLA
Thanks Mark for your comments. On 15/08/13 09:49, Mark Rutland wrote: > On Wed, Aug 14, 2013 at 06:27:01PM +0100, Srinivas KANDAGATLA wrote: >> From: Srinivas Kandagatla >> >> This patch adds support to ST RC driver, which is basically a IR/UHF >> receiver and transmitter. This IP is common acros

Re: [PATCH] media: st-rc: Add ST remote control driver

2013-08-15 Thread Mark Rutland
On Wed, Aug 14, 2013 at 06:27:01PM +0100, Srinivas KANDAGATLA wrote: > From: Srinivas Kandagatla > > This patch adds support to ST RC driver, which is basically a IR/UHF > receiver and transmitter. This IP is common across all the ST parts for > settop box platforms. IRB is embedded in ST COMMS I

[PATCH] media: st-rc: Add ST remote control driver

2013-08-14 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla This patch adds support to ST RC driver, which is basically a IR/UHF receiver and transmitter. This IP is common across all the ST parts for settop box platforms. IRB is embedded in ST COMMS IP block. It supports both Rx & Tx functionality. In this driver adds only Rx f