Re: [PATCH] media: i2c: add driver for dual LED Flash, lm3560.

2013-09-20 Thread Sakari Ailus
Hi Daniel, A few more comments. On Wed, Sep 11, 2013 at 04:45:31PM +0900, Daniel Jeong wrote: ... > +struct lm3560_flash { > + struct lm3560_platform_data *pdata; > + struct regmap *regmap; > + struct mutex power_lock; > + int power_count; > + > + enum v4l2_flash_led_mode led_

Re: [PATCH] media: i2c: add driver for dual LED Flash, lm3560.

2013-09-20 Thread Sakari Ailus
Hi Daniel, Thanks for the patch! It's very nice and clean in general. I've got a few comments below. On Wed, Sep 11, 2013 at 04:45:31PM +0900, Daniel Jeong wrote: > This patch includes the driver for the LM3560, dual LED Flash. > The LM3560 has two 1A constant current drivers for high current >

[PATCH] media: i2c: add driver for dual LED Flash, lm3560.

2013-09-11 Thread Daniel Jeong
This patch includes the driver for the LM3560, dual LED Flash. The LM3560 has two 1A constant current drivers for high current white LEDs. It is controlled via an I2C compatible interface(up to 400kHz). And each flash, torch brightness and enable/disable LED can be controlled independantly. Bu