Re: [PATCH] media: i2c: OV5647: gate clock lane before stream on

2017-09-10 Thread Jacob Chen
Hi Luis, 2017-08-07 22:48 GMT+08:00 Luis Oliveira : > Hi all, > > I'm new here, I got to be Maintainer of this driver by the old Maintainer > recommendation. Still getting the hang of it :) > > On 07-Aug-17 13:26, Philipp Zabel wrote: >> Hi Jacob, >> >> On Mon, 2017-08-07 at 19:06 +0800, Jacob Che

Re: [PATCH] media: i2c: OV5647: gate clock lane before stream on

2017-08-07 Thread Jacob Chen
Hi all, 2017-08-07 22:48 GMT+08:00 Luis Oliveira : > Hi all, > > I'm new here, I got to be Maintainer of this driver by the old Maintainer > recommendation. Still getting the hang of it :) > > On 07-Aug-17 13:26, Philipp Zabel wrote: >> Hi Jacob, >> >> On Mon, 2017-08-07 at 19:06 +0800, Jacob Chen

Re: [PATCH] media: i2c: OV5647: gate clock lane before stream on

2017-08-07 Thread Luis Oliveira
Hi all, I'm new here, I got to be Maintainer of this driver by the old Maintainer recommendation. Still getting the hang of it :) On 07-Aug-17 13:26, Philipp Zabel wrote: > Hi Jacob, > > On Mon, 2017-08-07 at 19:06 +0800, Jacob Chen wrote: > [...] > --- a/drivers/media/i2c/ov5647.c > +++

Re: [PATCH] media: i2c: OV5647: gate clock lane before stream on

2017-08-07 Thread Philipp Zabel
Hi Jacob, On Mon, 2017-08-07 at 19:06 +0800, Jacob Chen wrote: [...] > >> > --- a/drivers/media/i2c/ov5647.c > >> > +++ b/drivers/media/i2c/ov5647.c > >> > @@ -253,6 +253,10 @@ static int ov5647_stream_on(struct v4l2_subdev *sd) > >> > { > >> > int ret; > >> > > >> > + ret = ov5647_

Re: [PATCH] media: i2c: OV5647: gate clock lane before stream on

2017-08-07 Thread Jacob Chen
Hi Philipp, 2017-08-07 16:17 GMT+08:00 Philipp Zabel : > Hi Jacob, > > On Mon, 2017-08-07 at 15:11 +0800, Jacob Chen wrote: >> Hi all, >> >> 2017-07-25 10:34 GMT+08:00 Jacob Chen : >> > According to datasheet, BIT5 in reg-0x4800 are used to >> > enable/disable clock lane gate. >> > >> > It's wrong

Re: [PATCH] media: i2c: OV5647: gate clock lane before stream on

2017-08-07 Thread Philipp Zabel
Hi Jacob, On Mon, 2017-08-07 at 15:11 +0800, Jacob Chen wrote: > Hi all, > > 2017-07-25 10:34 GMT+08:00 Jacob Chen : > > According to datasheet, BIT5 in reg-0x4800 are used to > > enable/disable clock lane gate. > > > > It's wrong to make clock lane free running before > > sensor stream on was ca

Re: [PATCH] media: i2c: OV5647: gate clock lane before stream on

2017-08-07 Thread Jacob Chen
Hi all, 2017-07-25 10:34 GMT+08:00 Jacob Chen : > According to datasheet, BIT5 in reg-0x4800 are used to > enable/disable clock lane gate. > > It's wrong to make clock lane free running before > sensor stream on was called, while the mipi phy > are not initialized. > > Signed-off-by: Jacob Chen >

[PATCH] media: i2c: OV5647: gate clock lane before stream on

2017-07-24 Thread Jacob Chen
According to datasheet, BIT5 in reg-0x4800 are used to enable/disable clock lane gate. It's wrong to make clock lane free running before sensor stream on was called, while the mipi phy are not initialized. Signed-off-by: Jacob Chen --- drivers/media/i2c/ov5647.c | 10 +- 1 file changed,