Re: [PATCH] media: i2c/adp1653: set enable gpio to output

2015-06-16 Thread Pavel Machek
On Fri 2015-06-12 09:47:28, Uwe Kleine-König wrote: > Without setting the direction of a gpio to output a call to > gpiod_set_value doesn't have a defined outcome. > > Furthermore this is one caller less that stops us making the flags > argument to gpiod_get*() mandatory. > > Signed-off-by: Uwe K

Re: [PATCH] media: i2c/adp1653: set enable gpio to output

2015-06-12 Thread Sakari Ailus
Hallo Uwe, Thanks for the patch! On Fri, Jun 12, 2015 at 09:47:28AM +0200, Uwe Kleine-König wrote: > Without setting the direction of a gpio to output a call to > gpiod_set_value doesn't have a defined outcome. > > Furthermore this is one caller less that stops us making the flags > argument to

[PATCH] media: i2c/adp1653: set enable gpio to output

2015-06-12 Thread Uwe Kleine-König
Without setting the direction of a gpio to output a call to gpiod_set_value doesn't have a defined outcome. Furthermore this is one caller less that stops us making the flags argument to gpiod_get*() mandatory. Signed-off-by: Uwe Kleine-König --- Hello, this patch applies to next and is only ne