Re: [PATCH] media: davinci: vpbe: missing clk_put

2014-11-07 Thread Prabhakar Lad
Hi, Thanks for the patch! On Thu, Nov 6, 2014 at 1:04 PM, Sudip Mukherjee wrote: > we are getting struct clk using clk_get before calling > clk_prepare_enable. but if clk_prepare_enable fails, then we are > jumping to fail_mutex_unlock where we are just unlocking the mutex, > but we are not free

[PATCH] media: davinci: vpbe: missing clk_put

2014-11-06 Thread Sudip Mukherjee
we are getting struct clk using clk_get before calling clk_prepare_enable. but if clk_prepare_enable fails, then we are jumping to fail_mutex_unlock where we are just unlocking the mutex, but we are not freeing the clock source. this patch just adds a call to clk_put before jumping to fail_mutex_un