Re: [PATCH] media: am437x: Don't release OF node reference twice

2015-02-23 Thread Benoit Parrot
Thanks for the patch. Acked-by: Benoit Parrot Laurent Pinchart wrote on Mon [2015-Feb-23 16:49:21 +0200]: > The remote port reference is released both at the end of the OF graph > parsing loop, and in the error code path at the end of the function. > Those two calls will release the same refer

Re: [PATCH] media: am437x: Don't release OF node reference twice

2015-02-23 Thread Lad, Prabhakar
Hi Laurent, Thanks for the patch. On Mon, Feb 23, 2015 at 2:49 PM, Laurent Pinchart wrote: > The remote port reference is released both at the end of the OF graph > parsing loop, and in the error code path at the end of the function. > Those two calls will release the same reference, causing the

[PATCH] media: am437x: Don't release OF node reference twice

2015-02-23 Thread Laurent Pinchart
The remote port reference is released both at the end of the OF graph parsing loop, and in the error code path at the end of the function. Those two calls will release the same reference, causing the reference count to go negative. Fix the problem by removing the second call. Signed-off-by: Laure