Re: [PATCH] media/i2c: don't return ENOTTY if SUBDEV_API is not set

Hi Hans, On Wed 17 Jul 2019 at 10:24, Hans Verkuil wrote: > If CONFIG_VIDEO_V4L2_SUBDEV_API is not set, then it is still possible > to call set_fmt for V4L2_SUBDEV_FORMAT_TRY, the result is just not > stored. So return 0 instead of -ENOTTY. > > Calling get_fmt with V4L2_SUBDEV_FORMAT_TRY should ret

Re: [PATCH] media/i2c: don't return ENOTTY if SUBDEV_API is not set

Hi Hans, Thank you for the patch. On Wed, Jul 17, 2019 at 10:24 AM Hans Verkuil wrote: > > If CONFIG_VIDEO_V4L2_SUBDEV_API is not set, then it is still possible > to call set_fmt for V4L2_SUBDEV_FORMAT_TRY, the result is just not > stored. So return 0 instead of -ENOTTY. > > Calling get_fmt with

[PATCH] media/i2c: don't return ENOTTY if SUBDEV_API is not set

If CONFIG_VIDEO_V4L2_SUBDEV_API is not set, then it is still possible to call set_fmt for V4L2_SUBDEV_FORMAT_TRY, the result is just not stored. So return 0 instead of -ENOTTY. Calling get_fmt with V4L2_SUBDEV_FORMAT_TRY should return -EINVAL instead of -ENOTTY, after all the get_fmt functionality