Re: [PATCH] media/at91sam9x5-video: new driver for the high end overlay on at91sam9x5

2011-07-03 Thread Uwe Kleine-König
Hello Sylwester, On Sun, Jul 03, 2011 at 05:29:25PM +0200, Sylwester Nawrocki wrote: > On 07/02/2011 10:09 PM, Uwe Kleine-König wrote: > >>> + if (rect->left< 0) > >>> + hwxpos = 0; > >>> + else > >>> + hwxpos = rect->left; > >> > >> Could be rewritten as: > >> > >>hwxpos = r

Re: [PATCH] media/at91sam9x5-video: new driver for the high end overlay on at91sam9x5

2011-07-03 Thread Sylwester Nawrocki
Hello Uwe, On 07/02/2011 10:09 PM, Uwe Kleine-König wrote: > Hello Sylwester, > > thanks for your feedback. A few comments below. For the statements I > don't reply to, you can consider a "OK, will be fixed in v2". > > On Fri, Jul 01, 2011 at 11:20:32PM +0200, Sylwester Nawrocki wrote: >> On 06/

Re: [PATCH] media/at91sam9x5-video: new driver for the high end overlay on at91sam9x5

2011-07-02 Thread Uwe Kleine-König
Hello Sylwester, thanks for your feedback. A few comments below. For the statements I don't reply to, you can consider a "OK, will be fixed in v2". On Fri, Jul 01, 2011 at 11:20:32PM +0200, Sylwester Nawrocki wrote: > On 06/29/2011 09:58 PM, Uwe Kleine-König wrote: > > + if (handled& heoimr) >

Re: [PATCH] media/at91sam9x5-video: new driver for the high end overlay on at91sam9x5

2011-07-01 Thread Sylwester Nawrocki
Hi Uwe, On 06/29/2011 09:58 PM, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König > --- > Hello, > > this is a driver that is still classified as work in progress. There are > some known problems with it, still following the "release early, release > often" principle I'd be happy to get s

[PATCH] media/at91sam9x5-video: new driver for the high end overlay on at91sam9x5

2011-06-29 Thread Uwe Kleine-König
Signed-off-by: Uwe Kleine-König --- Hello, this is a driver that is still classified as work in progress. There are some known problems with it, still following the "release early, release often" principle I'd be happy to get some feed back from you. Here is a list of know deficiencies: - There