Re: [PATCH] libv4l: add NULL pointer check

2009-09-01 Thread Hans de Goede
Hi, On 08/30/2009 10:56 AM, Németh Márton wrote: From: Márton Németh Add NULL pointer check before the pointers are dereferenced. The patch was tested with v4l-test 0.19 [1] together with "Trust 610 LCD pow...@m Zoom" in webcam mode. http://linuxtv.org/hg/~hgoede/libv4l/rev/c51a90c0f62f Re

Re: [PATCH] libv4l: add NULL pointer check

2009-08-31 Thread Németh Márton
Laurent Pinchart wrote: > On Monday 31 August 2009 15:19:32 Mauro Carvalho Chehab wrote: >> Em Mon, 31 Aug 2009 08:52:38 +0200 >> >> Laurent Pinchart escreveu: - dereferencing a NULL pointer is not always result segfault, see [1] and [2]. So dereferencing a NULL pointer can be treated a

Re: [PATCH] libv4l: add NULL pointer check

2009-08-31 Thread Laurent Pinchart
On Monday 31 August 2009 15:19:32 Mauro Carvalho Chehab wrote: > Em Mon, 31 Aug 2009 08:52:38 +0200 > > Laurent Pinchart escreveu: > > > - dereferencing a NULL pointer is not always result segfault, see [1] > > > and [2]. So dereferencing a NULL pointer can be treated also as a > > > security ris

Re: [PATCH] libv4l: add NULL pointer check

2009-08-31 Thread Mauro Carvalho Chehab
Em Mon, 31 Aug 2009 08:52:38 +0200 Laurent Pinchart escreveu: > > - dereferencing a NULL pointer is not always result segfault, see [1] and > >[2]. So dereferencing a NULL pointer can be treated also as a security > >risk. >From kernelspace drivers POV, any calls sending a NULL pointe

Re: [PATCH] libv4l: add NULL pointer check

2009-08-30 Thread Laurent Pinchart
On Monday 31 August 2009 07:51:28 Németh Márton wrote: > Laurent Pinchart wrote: > > On Sunday 30 August 2009 10:56:16 Németh Márton wrote: > > > From: Márton Németh > > > > > > Add NULL pointer check before the pointers are dereferenced. > > > > Applications are not supposed to pass NULL pointers

Re: [PATCH] libv4l: add NULL pointer check

2009-08-30 Thread Németh Márton
Laurent Pinchart wrote: > On Sunday 30 August 2009 10:56:16 Németh Márton wrote: >> From: Márton Németh >> >> Add NULL pointer check before the pointers are dereferenced. > > Applications are not supposed to pass NULL pointers to those functions. It > would be an API violation. Instead of silent

Re: [PATCH] libv4l: add NULL pointer check

2009-08-30 Thread Laurent Pinchart
On Sunday 30 August 2009 10:56:16 Németh Márton wrote: > From: Márton Németh > > Add NULL pointer check before the pointers are dereferenced. Applications are not supposed to pass NULL pointers to those functions. It would be an API violation. Instead of silently failing a segfault is better. >

[PATCH] libv4l: add NULL pointer check

2009-08-30 Thread Németh Márton
From: Márton Németh Add NULL pointer check before the pointers are dereferenced. The patch was tested with v4l-test 0.19 [1] together with "Trust 610 LCD pow...@m Zoom" in webcam mode. Reference: [1] v4l-test: Test environment for Video For Linux Two API http://v4l-test.sourceforge.net/ Pr