Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-20 Thread Steve Longerbeam
On 06/20/2018 01:54 AM, Philipp Zabel wrote: Hi Steve, On Tue, 2018-06-19 at 18:30 -0700, Steve Longerbeam wrote: I've found some time to diagnose the behavior of interweave with B/T line swapping (to support interlaced-bt) with planar formats. There are a couple problems (one known and one

Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-20 Thread Philipp Zabel
Hi Steve, On Tue, 2018-06-19 at 18:30 -0700, Steve Longerbeam wrote: > Hi Philipp, Krzysztof, > > On 06/15/2018 01:33 AM, Krzysztof Hałasa wrote: > > Steve Longerbeam writes: > > > > > Right, the selection of interweave is moved to the capture devices, > > > so the following will enable interwe

Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-19 Thread Steve Longerbeam
Hi Philipp, Krzysztof, On 06/15/2018 01:33 AM, Krzysztof Hałasa wrote: Steve Longerbeam writes: Right, the selection of interweave is moved to the capture devices, so the following will enable interweave: v4l2-ctl -dN --set-fmt-video=field=interlaced_tb and So the patch to adv7180 needs

Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-15 Thread Krzysztof Hałasa
Steve Longerbeam writes: > Right, the selection of interweave is moved to the capture devices, > so the following will enable interweave: > > v4l2-ctl -dN --set-fmt-video=field=interlaced_tb and > So the patch to adv7180 needs to be modified to report # field lines. > > Try the following: > > -

Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-14 Thread Steve Longerbeam
Hi Krzysztof, On 06/14/2018 02:39 AM, Krzysztof Hałasa wrote: Reporting from the field :-) The fix-csi-interlaced.3 branch is still a bit off the track I guess: Yes, it's still a WIP. A couple things are remaining: - fix interweave with negative offsets for planar pixel formats. - update th

Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-14 Thread Krzysztof Hałasa
Reporting from the field :-) The fix-csi-interlaced.3 branch is still a bit off the track I guess: media-ctl -V "'adv7180 2-0020':0 [fmt:UYVY2X8/576 field:seq-tb]" media-ctl -V "'ipu2_csi1_mux':2 [fmt:UYVY2X8/720x576]" media-ctl -V "'ipu2_csi1':2 [fmt:AYUV32/720x576 field:interlaced-tb]"

Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-12 Thread Steve Longerbeam
Hi Javier, thanks for the confirmations. I'm working on a fix for imx-media. Steve On 06/12/2018 10:27 AM, Javier Martinez Canillas wrote: Hi Steve, On 06/11/2018 11:06 PM, Steve Longerbeam wrote: [snip] I've been made aware [1] that recently V4L2_FIELD_ALTERNATE has been clarified [2] to

Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-12 Thread Javier Martinez Canillas
Hi Steve, On 06/11/2018 11:06 PM, Steve Longerbeam wrote: [snip] >> >> I've been made aware [1] that recently V4L2_FIELD_ALTERNATE has been >> clarified [2] to specify that v4l2_mbus_fmt.height should contain the >> number of lines per field, not per frame: > > Yep! That was nagging at me as we

Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-12 Thread Philipp Zabel
On Mon, 2018-06-11 at 14:06 -0700, Steve Longerbeam wrote: > > On 06/11/2018 02:19 AM, Philipp Zabel wrote: > > Hi Steve, > > > > On Sun, 2018-06-10 at 17:08 -0700, Steve Longerbeam wrote: > > > Hi Philipp, > > > > > > On 06/01/2018 06:13 AM, Philipp Zabel wrote: > > > > The IPU also supports in

Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-11 Thread Steve Longerbeam
On 06/11/2018 02:19 AM, Philipp Zabel wrote: Hi Steve, On Sun, 2018-06-10 at 17:08 -0700, Steve Longerbeam wrote: Hi Philipp, On 06/01/2018 06:13 AM, Philipp Zabel wrote: The IPU also supports interlaced buffers that start with the bottom field. To achieve this, the the base address EBA ha

Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-11 Thread Philipp Zabel
Hi Steve, On Sun, 2018-06-10 at 17:08 -0700, Steve Longerbeam wrote: > Hi Philipp, > > On 06/01/2018 06:13 AM, Philipp Zabel wrote: > > The IPU also supports interlaced buffers that start with the bottom field. > > To achieve this, the the base address EBA has to be increased by a stride > > leng

Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-10 Thread Steve Longerbeam
Hi Philipp, On 06/01/2018 06:13 AM, Philipp Zabel wrote: The IPU also supports interlaced buffers that start with the bottom field. To achieve this, the the base address EBA has to be increased by a stride length and the interlace offset ILO has to be set to the negative stride. Signed-off-by:

[PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-01 Thread Philipp Zabel
The IPU also supports interlaced buffers that start with the bottom field. To achieve this, the the base address EBA has to be increased by a stride length and the interlace offset ILO has to be set to the negative stride. Signed-off-by: Philipp Zabel --- drivers/gpu/ipu-v3/ipu-cpmem.c | 8 +