Re: [PATCH] em28xx: overhaul em28xx_capture_area_set()

2013-02-06 Thread Frank Schäfer
Am 05.02.2013 23:48, schrieb Mauro Carvalho Chehab: > Em Sun, 20 Jan 2013 14:26:47 +0100 > Frank Schäfer escreveu: > >> - move the bit shifting of width+height values inside the function >> - fix the debug message format and output values >> - add comment about the size limit (e.g. EM277x supports

Re: [PATCH] em28xx: overhaul em28xx_capture_area_set()

2013-02-05 Thread Mauro Carvalho Chehab
Em Sun, 20 Jan 2013 14:26:47 +0100 Frank Schäfer escreveu: > - move the bit shifting of width+height values inside the function > - fix the debug message format and output values > - add comment about the size limit (e.g. EM277x supports >2MPix) > - make void, because error checking is incomplete

[PATCH] em28xx: overhaul em28xx_capture_area_set()

2013-01-20 Thread Frank Schäfer
- move the bit shifting of width+height values inside the function - fix the debug message format and output values - add comment about the size limit (e.g. EM277x supports >2MPix) - make void, because error checking is incomplete and we never check the returned value (we would continue anyway)