On Thursday 30 July 2009 05:06:34 Mauro Carvalho Chehab wrote:
> Em Wed, 29 Jul 2009 17:08:31 +0200
> "Hans Verkuil" escreveu:
>
> > > I did some tests here: if we replace -EINVAL with -ENOIOCTLCMD, we can
> > > properly
> > > make v4l2_device_call_until_err() to work, fixing the lack of a proper
Em Wed, 29 Jul 2009 18:13:36 -0400
ac...@fastmail.fm escreveu:
> On Wed, Jul 29, 2009 at 01:57:30AM -0300, Mauro Carvalho Chehab wrote:
> > Ah, yes, there's a missing mute/unmute issue there. Instead of using
> > your code, I opted to duplicate part of ac97_set_ctrl code there.
> >
> > I opted to
Em Wed, 29 Jul 2009 17:08:31 +0200
"Hans Verkuil" escreveu:
> > I did some tests here: if we replace -EINVAL with -ENOIOCTLCMD, we can
> > properly
> > make v4l2_device_call_until_err() to work, fixing the lack of a proper
> > error
> > report at the drivers. This error code seems also appropriat
On Wed, Jul 29, 2009 at 01:57:30AM -0300, Mauro Carvalho Chehab wrote:
> Ah, yes, there's a missing mute/unmute issue there. Instead of using
> your code, I opted to duplicate part of ac97_set_ctrl code there.
>
> I opted to have a small duplicated code, but, IMO, it is now clearer
> to see why we
> Em Wed, 29 Jul 2009 15:14:22 +0200
> "Hans Verkuil" escreveu:
>
>>
>> > Em Wed, 29 Jul 2009 08:09:31 +0200
>> > Hans Verkuil escreveu:
>> >
>> >> On Wednesday 29 July 2009 06:57:30 Mauro Carvalho Chehab wrote:
>> >> > Hans,
>> >> >
>> >> > we need to fix the returned error value for v4l2_de
Em Wed, 29 Jul 2009 15:14:22 +0200
"Hans Verkuil" escreveu:
>
> > Em Wed, 29 Jul 2009 08:09:31 +0200
> > Hans Verkuil escreveu:
> >
> >> On Wednesday 29 July 2009 06:57:30 Mauro Carvalho Chehab wrote:
> >> > Em Tue, 28 Jul 2009 20:07:53 -0400
> >> >
> >> > ac...@fastmail.fm escreveu:
> >> > > O
> Em Wed, 29 Jul 2009 08:09:31 +0200
> Hans Verkuil escreveu:
>
>> On Wednesday 29 July 2009 06:57:30 Mauro Carvalho Chehab wrote:
>> > Em Tue, 28 Jul 2009 20:07:53 -0400
>> >
>> > ac...@fastmail.fm escreveu:
>> > > On Mon, Jul 27, 2009 at 09:28:11PM -0300, Mauro Carvalho Chehab
>> wrote:
>> > >
Em Wed, 29 Jul 2009 08:09:31 +0200
Hans Verkuil escreveu:
> On Wednesday 29 July 2009 06:57:30 Mauro Carvalho Chehab wrote:
> > Em Tue, 28 Jul 2009 20:07:53 -0400
> >
> > ac...@fastmail.fm escreveu:
> > > On Mon, Jul 27, 2009 at 09:28:11PM -0300, Mauro Carvalho Chehab wrote:
> > > > Hi Acano,
> >
On Wednesday 29 July 2009 06:57:30 Mauro Carvalho Chehab wrote:
> Em Tue, 28 Jul 2009 20:07:53 -0400
>
> ac...@fastmail.fm escreveu:
> > On Mon, Jul 27, 2009 at 09:28:11PM -0300, Mauro Carvalho Chehab wrote:
> > > Hi Acano,
> >
> > Tested-by: Angelo Cano
> >
> > works great
>
> Good!
>
> > > > +
Em Tue, 28 Jul 2009 20:07:53 -0400
ac...@fastmail.fm escreveu:
> On Mon, Jul 27, 2009 at 09:28:11PM -0300, Mauro Carvalho Chehab wrote:
> > Hi Acano,
>
> Tested-by: Angelo Cano
>
> works great
Good!
> > > + /*FIXME hack to unmute usb audio stream */
> > > + em28xx_set_ctrl(dev
On Mon, Jul 27, 2009 at 09:28:11PM -0300, Mauro Carvalho Chehab wrote:
> Hi Acano,
Tested-by: Angelo Cano
works great
> > + /*FIXME hack to unmute usb audio stream */
> > + em28xx_set_ctrl(dev, ctrl);
>
> Hmm... this function were removed. In thesis, you shouldn't need to
>
Hi Acano,
Em Sat, 18 Jul 2009 13:37:58 -0400
ac...@fastmail.fm escreveu:
> @@ -1950,6 +1950,10 @@ void em28xx_pre_card_setup(struct em28xx
> /* FIXME guess */
> /* Turn on analog audio output */
> em28xx_write_reg(dev, EM28XX_R08_GPIO, 0xfd);
This is leg
diff -r 27ddf3fe0ed9 linux/drivers/media/video/em28xx/em28xx-cards.c
--- a/linux/drivers/media/video/em28xx/em28xx-cards.c Wed Jun 17 04:38:12 2009 +
+++ b/linux/drivers/media/video/em28xx/em28xx-cards.c Sat Jul 18 13:32:04 2009 -0400
@@ -639,10 +639,10 @@ struct em28xx_board em28xx_boards[] =
13 matches
Mail list logo
