Re: [PATCH] drivers: media: video: Add support for Aptina ar0130 sensor

2012-09-11 Thread Nicolas THERY
Hello, I've spotted a minor issue while glancing through the code. Cheers, Nicolas On 2012-09-07 11:30, Prashanth Subramanya wrote: > This driver adds basic support for Aptina ar0130 1.2M sensor. > > Signed-off-by: Prashanth Subramanya > --- [snip] > +/*

Re: [PATCH] drivers: media: video: Add support for Aptina ar0130 sensor

2012-09-09 Thread Guennadi Liakhovetski
Hi Prashanth On Fri, 7 Sep 2012, Prashanth Subramanya wrote: > This driver adds basic support for Aptina ar0130 1.2M sensor. > > Signed-off-by: Prashanth Subramanya > --- > drivers/media/video/Kconfig |7 + > drivers/media/video/Makefile |1 + > drivers/media/video/ar0130.c

Re: [PATCH] drivers: media: video: Add support for Aptina ar0130 sensor

2012-09-07 Thread Hans Verkuil
Hi Prashanth! Thanks for working on this driver. I do have a few comments about this driver, mostly coding style and v4l2 API related things. On Fri September 7 2012 11:30:26 Prashanth Subramanya wrote: > This driver adds basic support for Aptina ar0130 1.2M sensor. > > Signed-off-by: Prashanth

[PATCH] drivers: media: video: Add support for Aptina ar0130 sensor

2012-09-07 Thread Prashanth Subramanya
This driver adds basic support for Aptina ar0130 1.2M sensor. Signed-off-by: Prashanth Subramanya --- drivers/media/video/Kconfig |7 + drivers/media/video/Makefile |1 + drivers/media/video/ar0130.c | 1114 + drivers/media/video/ar0130