Re: [PATCH] drivers/media: nuvoton: always true expression

2010-11-16 Thread Mauro Carvalho Chehab
Em 16-11-2010 19:54, Jarod Wilson escreveu: > On Tue, Nov 16, 2010 at 09:19:53PM +0100, Nicolas Kaiser wrote: >> I noticed that the second part of this conditional is always true. >> Would the intention be to strictly check on both chip_major and >> chip_minor? >> >> Signed-off-by: Nicolas Kaiser

Re: [PATCH] drivers/media: nuvoton: always true expression

2010-11-16 Thread Jarod Wilson
On Tue, Nov 16, 2010 at 09:19:53PM +0100, Nicolas Kaiser wrote: > I noticed that the second part of this conditional is always true. > Would the intention be to strictly check on both chip_major and > chip_minor? > > Signed-off-by: Nicolas Kaiser Hrm, yeah, looks like I screwed that one up. You'

[PATCH] drivers/media: nuvoton: always true expression

2010-11-16 Thread Nicolas Kaiser
I noticed that the second part of this conditional is always true. Would the intention be to strictly check on both chip_major and chip_minor? Signed-off-by: Nicolas Kaiser --- drivers/media/IR/nuvoton-cir.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/medi