Re: [PATCH] drivers/media: don't set pix->priv = 0

2019-06-26 Thread Hans Verkuil
On 6/26/19 3:55 PM, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Wed, Jun 26, 2019 at 11:58:02AM +0200, Hans Verkuil wrote: >> The priv field of struct v4l2_pix_format shouldn't be set by drivers, >> it's set by the v4l2 core instead to V4L2_PIX_FMT_PRIV_MAGIC. >> >> Dro

Re: [PATCH] drivers/media: don't set pix->priv = 0

2019-06-26 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Wed, Jun 26, 2019 at 11:58:02AM +0200, Hans Verkuil wrote: > The priv field of struct v4l2_pix_format shouldn't be set by drivers, > it's set by the v4l2 core instead to V4L2_PIX_FMT_PRIV_MAGIC. > > Drop this from the few media drivers that still do this. >

[PATCH] drivers/media: don't set pix->priv = 0

2019-06-26 Thread Hans Verkuil
The priv field of struct v4l2_pix_format shouldn't be set by drivers, it's set by the v4l2 core instead to V4L2_PIX_FMT_PRIV_MAGIC. Drop this from the few media drivers that still do this. Note that the gspca patch is slightly more involved since some of the sub-gspca drivers use the priv field i