> I think we can pretty safely assume that we never get here with ov==NULL.
>
> Oh well, I'll leave the test there for others to ponder.
OK. I didn't read far enough in this email and sent another patch, in
case it's useful.
julia
--
To unsubscribe from this list: send the line "unsubscribe li
From: Julia Lawall
It seems impossible for ov to be NULL at this point.
The semantic match that finds the problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r exists@
expression E, E1;
identifier f;
statement S1,S3;
iterator iter;
@@
if ((E == NULL && ...) || ...)
{
... when != false (
On Sun, 21 Mar 2010 22:31:06 +0100 (CET) Julia Lawall wrote:
> From: Julia Lawall
>
> If ov is NULL, it will not be possible to take the lock in the first place,
> so move the test up earlier.
>
> ...
>
> --- a/drivers/media/video/ov511.c
> +++ b/drivers/media/video/ov511.c
> @@ -5913,14 +5913
From: Julia Lawall
If ov is NULL, it will not be possible to take the lock in the first place,
so move the test up earlier.
The semantic match that finds the problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r exists@
expression E, E1;
identifier f;
statement S1,S3;
iterator iter;
@@
if
