Re: [PATCH] drivers/media/IR/imon.c: Use pr_err instead of err

On Sun, Jun 20, 2010 at 12:53 PM, Joe Perches wrote: > On Sun, 2010-06-20 at 11:58 -0400, Jarod Wilson wrote: >> On Jun 20, 2010, at 3:20 AM, Joe Perches wrote: >> Use the standard error logging mechanisms. >> > Add #define pr_fmt(fmt) KBUILD_MODNAME ":%s" fmt, __func__ >> > Remove __func__ from

Re: [PATCH] drivers/media/IR/imon.c: Use pr_err instead of err

On Sun, 2010-06-20 at 11:58 -0400, Jarod Wilson wrote: > On Jun 20, 2010, at 3:20 AM, Joe Perches wrote: > Use the standard error logging mechanisms. > > Add #define pr_fmt(fmt) KBUILD_MODNAME ":%s" fmt, __func__ > > Remove __func__ from err calls, add '\n', rename to pr_err > Eh. If we're going t

Re: [PATCH] drivers/media/IR/imon.c: Use pr_err instead of err

On Jun 20, 2010, at 3:20 AM, Joe Perches wrote: Use the standard error logging mechanisms. Add #define pr_fmt(fmt) KBUILD_MODNAME ":%s" fmt, __func__ Remove __func__ from err calls, add '\n', rename to pr_err Signed-off-by: Joe Perches --- Eh. If we're going to make a change here, I'd rathe

[PATCH] drivers/media/IR/imon.c: Use pr_err instead of err

Use the standard error logging mechanisms. Add #define pr_fmt(fmt) KBUILD_MODNAME ":%s" fmt, __func__ Remove __func__ from err calls, add '\n', rename to pr_err Signed-off-by: Joe Perches --- drivers/media/IR/imon.c | 73 ++- 1 files changed, 34 inse