Re: [PATCH] dma-buf: propagate errors from dma_buf_describe() on debugfs read

2016-06-19 Thread Mathias Krause
On 19 June 2016 at 10:45, Daniel Vetter wrote: > On Fri, Jun 17, 2016 at 08:57:03PM +0200, Mathias Krause wrote: >> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c >> index 6355ab38d630..0f2a4592fdd2 100644 >> --- a/drivers/dma-buf/dma-buf.c >> +++ b/drivers/dma-buf/dma-buf.c >>

Re: [PATCH] dma-buf: propagate errors from dma_buf_describe() on debugfs read

2016-06-19 Thread Daniel Vetter
On Fri, Jun 17, 2016 at 08:57:03PM +0200, Mathias Krause wrote: > The callback function dma_buf_describe() returns an int not void so the > function pointer cast in dma_buf_show() is wrong. dma_buf_describe() can > also fail when acquiring the mutex gets interrupted so always returning > 0 in dma_b

[PATCH] dma-buf: propagate errors from dma_buf_describe() on debugfs read

2016-06-17 Thread Mathias Krause
The callback function dma_buf_describe() returns an int not void so the function pointer cast in dma_buf_show() is wrong. dma_buf_describe() can also fail when acquiring the mutex gets interrupted so always returning 0 in dma_buf_show() is wrong, too. Fix both issues by casting the function pointe